-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support using custom CNI #5217
Comments
Hi @jiayiwang7, @chrisdoherty4, Thanks a lot for working on this feature. We were really happy when we saw this listed in the release notes. We just want to cross check: did all the necessary commits made it to the v.0.15.0 release? If we check the list the commits since the last release (v.0.15.1) there seems to be still some commits related to this change:
Also note: these PR-s have still the milestone set to v0.15.0... |
Hi @Cajga. I've been out the last few weeks so hadn't seen your message. I'll get back to you soon. |
@Cajga, the commits were squashed into a single commit as seen in https://github.com/aws/eks-anywhere/pull/5366/commits, or cherry-picked so you won't see the commits from main. We'll reflect on our process to make identifying commits in release branches easier in the future. |
Hi @chrisdoherty4 , Thanks for confirming it. I was trying to figure it out myself but was not 100% sure what was happening. |
Sometimes user needs to use its own preferred CNI solution instead of EKS-A Cilium. It would be ideal if EKS-A can provide the possibility to swap out the default CNI with custom one, and EKS-A shall not revert the CNI changes made by the user during CLI upgrade / controller reconciliation.
In terms of solution, there are 2 routes we can go:
CustomCNI
field inClusterNetwork
where we apply the CNI manifests user input during create/upgrade workflow.UserManaged
field inClusterNetwork
indicating user is managing its own CNI. During cluster creation, we still install the default EKS-A Cilium CNI to guarantee the successful provision of the cluster. After the cluster is running, user can update theClusterNetwork
withUserManaged
true, manually delete the default EKS-A Cilium CNI and install custom CNI. Whenever theUserManaged
flag is presented, the EKS-A CLI upgrade and EKS-A controller will skip updating/applying Cilium components.We shall go with option 2 first, as option 1 is hard to validate and test given all the open options that exposes to the user. Also different CNI needs to be installed in various way, some of which cannot be set up properly with single manifest apply. The workflow to support it can be less trivial.
The text was updated successfully, but these errors were encountered: