-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add documentation for using a custom CNI #5408
Conversation
Skipping CI for Draft Pull Request. |
Codecov Report
@@ Coverage Diff @@
## main #5408 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 442 442
Lines 36739 36737 -2
=======================================
Hits 26713 26713
+ Misses 8426 8424 -2
Partials 1600 1600 see 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
||
{{% alert title="Warning" color="warning" %}} | ||
Clusters created using the Full Lifecycle Controller prior to v0.15 that have removed the EKS-A | ||
Cilium CNI must manually populate their `Cluster` object with the following annotation to ensure |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do they manually do this? via kubectl -f apply with an updated cluster spec?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's multiple ways to do it. Do we need to prescribe how? We could be clearer about the object they're editing though given there are multiple Cluster objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sentence may not be clear to newer users. I'm assuming the annotation goes on the Cluster
spec and I apply that via my choice of K8s API conformant tool (GitOps, Terraform, kubectl, etc.).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made clear its a cluster spec object and the exact object that needs annotating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In our docs, we try to avoid "EKS-A" and use the formal name "EKS Anywhere". Otherwise, the content looks good to me.
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisnegus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.15 |
@chrisnegus: once the present PR merges, I will cherry-pick it on top of release-0.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chrisnegus: new pull request created: #5469 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available: #5217
Description of changes:
Add documentation for using custom CNIs.