feature: add skip upgrade cilium CNI flag to API #5298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
size/S
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrisdoherty4 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report
@@ Coverage Diff @@
## main #5298 +/- ##
=======================================
Coverage 72.38% 72.39%
=======================================
Files 440 440
Lines 36130 36132 +2
=======================================
+ Hits 26154 26156 +2
Misses 8410 8410
Partials 1566 1566
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chrisdoherty4
changed the title
chrisdoherty4
changed the title
chrisdoherty4
changed the title
jiayiwang7
reviewed
Mar 20, 2023
| // be used when operators wish to self manage the Cilium installation. | ||
| // +kubebuilder:default=false | ||
| // +optional | ||
| SkipUpgrade *bool `json:"skipUpgrade,omitempty"` |
There was a problem hiding this comment.
why do we need a pointer here?
There was a problem hiding this comment.
To align with Kubernetes API conventions.
chrisdoherty4
changed the title
|
/lgtm |
eks-distro-bot
pushed a commit
that referenced
this pull request
Mar 23, 2023
* Update branch name * Update opencontainers/runc (#5306) * Add Cilium skipUpgrade flag to v1alpha1 API (#5298) * More 1.26 e2e tests (#5275) * Changing logic for removing hardware from catalogue (#5296) * Changing logic for removing hardware from catalogue to save list copy * Adding more unit tests and moving out key create * Revert "Update opencontainers/runc (#5306)" (#5309) This reverts commit b1681d6. * Validate Mgmt Cluster Bundles Version on Upgrade (#5263) Validates that the management cluster's bundle is the same version or newer than the bundle version used to upgrade a workload cluster. * change signaling method for FCL curated packages support (#5315) Previously, the creation a of package bundle controller was executed via a helm chart release. Now that helm chart will create a package instead. The end result being the same, that the packages controller will notice the newly created resource and do what it needs to support curated packages on the new workload cluster. One additional value is passed to the helm invocation to help the packages controller take the appropriate actions. * Make image-builder OS support and prerequisites section more clear (#5317) * Autogenerate eksctl anywhere command doc from code (#5299) * fix field to adapt to new schema (#5323) * Fix kubectl get call to point to full API name (#5326) * Fix providers to point to full API name * Fix * Fix unit-test * Fixing tink reconcile worker template omit and logs (#5246) * Implement unmanaged CNI for CLI based clusters (#5305) * Remove hardcoded artifact links in docs (#5320) * added insecure skip verify e2e test for 1.26 (#5322) * Validate Mgmt Cluster Bundles Version on Create (#5321) Validates that the management cluster's bundle is the same version or newer than the bundle version used to create a workload cluster. * Add doc for Nutanix projects and Terraform support (#5330) * Enable full lifecycle support for Tinkerbell (#5327) * Fix ECR endpoint URL in Harbor use-case doc (#5233) * add validation that checks if the OS is valid for the provided registry mirror configuration (#5314) * set management cluster name helm value (#5331) Passes the management cluster's name when installing curated packages on a workload cluster. Removes the workloadOnly flag, as it's no longer needed in this case, as the FCL/CLI curated packages installation for workload clusters is now triggered from the workloadPackageOnly flag. * Add insecureSkipVerify in registry mirror doc (#5339) * Expand all kubectl calls to fully qualified names (#5332) * Expand all kubectl calls to fully qualified names * Fix unit-test * Fix CAPI Machines * Add uncovered unit-tests - 1 * Fix harbor endpoint URL in docs (#5340) * Fix harbor endpoint URL in docs * Restored previous image * Add doc for harbor v2.7.1 (#5346) * add doc for harbor v2.7.1 * more updates * Add cluster lifecycle information to docs (#5302) * Add cluster lifecycle information to docs * Fixes from review comments * Add wording about upgrade and delete * Use default credential names if credential names are not set (#5324) Use `nutanix-credentials` as NutanixDatacenterConfig credentialRef name if it is not present. This ensures we don't get a nil-pointer dereference during upgrade and upgrade can happen smoothly. * Update e2e pkg metallb && Wait for pkg controller installation (#5351) * MetalLB tests for multiple k8s versions * Add e2e validation for package controller package installation * Packages e2e cluster spec (#5221) * Packages e2e tests for cluster spec * Packages e2e cluster spec * lint * Fix nutanix bad rebase * [PR BOT] Generate release test file (#5303) * skipping tink tests due to lack of resources (#5357) * [PR BOT] Update ATTRIBUTION.txt file (#5255) * add kernel settings for BR (#5304) * Bump Homebrew version for EKS-A v0.14.5 (#5355) * Backport v0.14.5 changelog to main (#5354) --------- Co-authored-by: Xu Deng <xudeng@amazon.com> Co-authored-by: Chris Doherty <chris.doherty4@gmail.com> Co-authored-by: Taylor Neyland <57606775+taneyland@users.noreply.github.com> Co-authored-by: Aravind Ramalingam <60027164+pokearu@users.noreply.github.com> Co-authored-by: Jonathan Meier <jonathanmeier5@users.noreply.github.com> Co-authored-by: Eric Wollesen <169516+ewollesen@users.noreply.github.com> Co-authored-by: Abhay Krishna <arnchlm@amazon.com> Co-authored-by: Joey Wang <jiayiwang7@yahoo.com> Co-authored-by: Vincent Ni <vincentni@users.noreply.github.com> Co-authored-by: Vignesh Goutham Ganesh <72776369+vignesh-goutham@users.noreply.github.com> Co-authored-by: Yannick Struyf <yannick.struyf@nutanix.com> Co-authored-by: Mitali Paygude <mitalipaygude@gmail.com> Co-authored-by: Hendry Anwar <hendry.anwar@live.com> Co-authored-by: Chris Negus <striker57@gmail.com> Co-authored-by: Sid Shukla <6081171+thunderboltsid@users.noreply.github.com> Co-authored-by: Lewis Diamond <git@lewisdiamond.com> Co-authored-by: Terry Howe <terrylhowe@gmail.com> Co-authored-by: EKS Distro PR Bot <75336432+eks-distro-pr-bot@users.noreply.github.com> Co-authored-by: ahreehong <46465244+ahreehong@users.noreply.github.com>
eks-distro-bot
pushed a commit
that referenced
this pull request
Mar 24, 2023
* Update opencontainers/runc (#5306) * Add Cilium skipUpgrade flag to v1alpha1 API (#5298) * More 1.26 e2e tests (#5275) * Changing logic for removing hardware from catalogue (#5296) * Changing logic for removing hardware from catalogue to save list copy * Adding more unit tests and moving out key create * Revert "Update opencontainers/runc (#5306)" (#5309) This reverts commit b1681d6. * Validate Mgmt Cluster Bundles Version on Upgrade (#5263) Validates that the management cluster's bundle is the same version or newer than the bundle version used to upgrade a workload cluster. * change signaling method for FCL curated packages support (#5315) Previously, the creation a of package bundle controller was executed via a helm chart release. Now that helm chart will create a package instead. The end result being the same, that the packages controller will notice the newly created resource and do what it needs to support curated packages on the new workload cluster. One additional value is passed to the helm invocation to help the packages controller take the appropriate actions. * Make image-builder OS support and prerequisites section more clear (#5317) * Autogenerate eksctl anywhere command doc from code (#5299) * fix field to adapt to new schema (#5323) * Fix kubectl get call to point to full API name (#5326) * Fix providers to point to full API name * Fix * Fix unit-test * Fixing tink reconcile worker template omit and logs (#5246) * Implement unmanaged CNI for CLI based clusters (#5305) * Remove hardcoded artifact links in docs (#5320) * added insecure skip verify e2e test for 1.26 (#5322) * Validate Mgmt Cluster Bundles Version on Create (#5321) Validates that the management cluster's bundle is the same version or newer than the bundle version used to create a workload cluster. * Add doc for Nutanix projects and Terraform support (#5330) * Enable full lifecycle support for Tinkerbell (#5327) * Fix ECR endpoint URL in Harbor use-case doc (#5233) * add validation that checks if the OS is valid for the provided registry mirror configuration (#5314) * set management cluster name helm value (#5331) Passes the management cluster's name when installing curated packages on a workload cluster. Removes the workloadOnly flag, as it's no longer needed in this case, as the FCL/CLI curated packages installation for workload clusters is now triggered from the workloadPackageOnly flag. * Add insecureSkipVerify in registry mirror doc (#5339) * Expand all kubectl calls to fully qualified names (#5332) * Expand all kubectl calls to fully qualified names * Fix unit-test * Fix CAPI Machines * Add uncovered unit-tests - 1 * Fix harbor endpoint URL in docs (#5340) * Fix harbor endpoint URL in docs * Restored previous image * Add doc for harbor v2.7.1 (#5346) * add doc for harbor v2.7.1 * more updates * Add cluster lifecycle information to docs (#5302) * Add cluster lifecycle information to docs * Fixes from review comments * Add wording about upgrade and delete * Use default credential names if credential names are not set (#5324) Use `nutanix-credentials` as NutanixDatacenterConfig credentialRef name if it is not present. This ensures we don't get a nil-pointer dereference during upgrade and upgrade can happen smoothly. * Update e2e pkg metallb && Wait for pkg controller installation (#5351) * MetalLB tests for multiple k8s versions * Add e2e validation for package controller package installation * Packages e2e cluster spec (#5221) * Packages e2e tests for cluster spec * Packages e2e cluster spec * lint * Fix nutanix bad rebase * [PR BOT] Generate release test file (#5303) * skipping tink tests due to lack of resources (#5357) * [PR BOT] Update ATTRIBUTION.txt file (#5255) * add kernel settings for BR (#5304) * Bump Homebrew version for EKS-A v0.14.5 (#5355) * Backport v0.14.5 changelog to main (#5354) * [PR BOT] Generate release testdata files (#5362) --------- Co-authored-by: Xu Deng <xudeng@amazon.com> Co-authored-by: Chris Doherty <chris.doherty4@gmail.com> Co-authored-by: Taylor Neyland <57606775+taneyland@users.noreply.github.com> Co-authored-by: Aravind Ramalingam <60027164+pokearu@users.noreply.github.com> Co-authored-by: Jonathan Meier <jonathanmeier5@users.noreply.github.com> Co-authored-by: Eric Wollesen <169516+ewollesen@users.noreply.github.com> Co-authored-by: Abhay Krishna <arnchlm@amazon.com> Co-authored-by: Joey Wang <jiayiwang7@yahoo.com> Co-authored-by: Vincent Ni <vincentni@users.noreply.github.com> Co-authored-by: Vignesh Goutham Ganesh <72776369+vignesh-goutham@users.noreply.github.com> Co-authored-by: Yannick Struyf <yannick.struyf@nutanix.com> Co-authored-by: Mitali Paygude <mitalipaygude@gmail.com> Co-authored-by: Hendry Anwar <hendry.anwar@live.com> Co-authored-by: Chris Negus <striker57@gmail.com> Co-authored-by: Sid Shukla <6081171+thunderboltsid@users.noreply.github.com> Co-authored-by: Lewis Diamond <git@lewisdiamond.com> Co-authored-by: Terry Howe <terrylhowe@gmail.com> Co-authored-by: EKS Distro PR Bot <75336432+eks-distro-pr-bot@users.noreply.github.com> Co-authored-by: ahreehong <46465244+ahreehong@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a flag -
skipUpgrade- to the Cilium configuration in our v1alpha1 API that will enable self managed CNIs.#5217