Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial implementation of generating snow objects for upgrade #1968

Closed
wants to merge 1 commit into from

Conversation

jiayiwang7
Copy link
Member

Issue #, if available:

Description of changes:

Testing (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from jiayiwang7 after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 28, 2022
pkg/providers/common/common.go Outdated Show resolved Hide resolved
pkg/providers/common/common.go Outdated Show resolved Hide resolved
pkg/providers/common/common.go Outdated Show resolved Hide resolved
pkg/providers/snow/fetch.go Outdated Show resolved Hide resolved
pkg/providers/snow/fetch.go Outdated Show resolved Hide resolved
pkg/providers/snow/objects.go Outdated Show resolved Hide resolved
pkg/providers/snow/objects.go Outdated Show resolved Hide resolved
pkg/providers/snow/objects.go Outdated Show resolved Hide resolved
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 29, 2022
@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 2, 2022
@jiayiwang7 jiayiwang7 force-pushed the snow-upgrade-1 branch 2 times, most recently from df6e529 to 8d18221 Compare May 2, 2022 16:50
@eks-distro-bot eks-distro-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 2, 2022
@codecov
Copy link

codecov bot commented May 2, 2022

Codecov Report

Merging #1968 (9c758b9) into main (64a1d2d) will increase coverage by 0.09%.
The diff coverage is 78.02%.

@@            Coverage Diff             @@
##             main    #1968      +/-   ##
==========================================
+ Coverage   50.18%   50.27%   +0.09%     
==========================================
  Files         295      298       +3     
  Lines       24838    25010     +172     
==========================================
+ Hits        12464    12573     +109     
- Misses      11074    11129      +55     
- Partials     1300     1308       +8     
Impacted Files Coverage Δ
pkg/clients/kubernetes/kubeconfig.go 100.00% <ø> (ø)
pkg/clients/kubernetes/scheme.go 50.00% <ø> (ø)
pkg/dependencies/factory.go 50.33% <0.00%> (+0.08%) ⬆️
pkg/clients/kubernetes/unauth.go 90.00% <33.33%> (-10.00%) ⬇️
pkg/providers/snow/snow.go 50.00% <59.09%> (-2.74%) ⬇️
pkg/providers/snow/objects.go 79.16% <79.16%> (ø)
pkg/clusterapi/name.go 83.33% <83.33%> (ø)
pkg/clusterapi/apibuilder.go 90.43% <100.00%> (ø)
pkg/clustermanager/cluster_manager.go 53.46% <100.00%> (-0.17%) ⬇️
pkg/providers/snow/apibuilder.go 92.37% <100.00%> (ø)
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 64a1d2d...9c758b9. Read the comment docs.

@eks-distro-bot eks-distro-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels May 2, 2022
@jiayiwang7 jiayiwang7 marked this pull request as ready for review May 2, 2022 22:31
@jiayiwang7 jiayiwang7 force-pushed the snow-upgrade-1 branch 3 times, most recently from ab95ac5 to 493992f Compare May 3, 2022 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants