Generate CAPI objects for snow upgrade and create #1999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XL
Codecov Report
@@ Coverage Diff @@
## main #1999 +/- ##
==========================================
+ Coverage 50.15% 50.29% +0.13%
==========================================
Files 296 298 +2
Lines 24940 25024 +84
==========================================
+ Hits 12509 12586 +77
- Misses 11125 11129 +4
- Partials 1306 1309 +3
Continue to review full report at Codecov.
|
g-gaston
reviewed
May 3, 2022
g-gaston
approved these changes
May 3, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1106
Break down the POC upgrade PR #1968
Description of changes:
This PR compares the existing snowmachinetemplate in cluster and the snowmachinetemplate generated from cluster spec, to determine whether to create new machinetemplate since the object is immutable.
The
snow.CAPIObjects(ctx context.Context, clusterSpec *cluster.Spec, kubeClient kubernetes.Client)is sharable between cli and controller.Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.