-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for node taints and labels for tinkerbell provider #2480
Add support for node taints and labels for tinkerbell provider #2480
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2480 +/- ##
==========================================
+ Coverage 57.17% 57.23% +0.06%
==========================================
Files 310 310
Lines 25334 25320 -14
==========================================
+ Hits 14484 14493 +9
+ Misses 9524 9505 -19
+ Partials 1326 1322 -4
Continue to review full report at Codecov.
|
b2612ae
to
85d5c05
Compare
85d5c05
to
773e9a3
Compare
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ptrivedi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/cherry-pick release-0.10 |
@abhinavmpandey08: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test eks-anywhere-e2e-presubmit |
/retest |
@abhinavmpandey08: #2480 failed to apply on top of branch "release-0.10":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.10 |
@abhinavmpandey08: new pull request created: #2527 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
Add support for node taints and node labels for tinkerbell provider.
This feature already exists for the other providers. Here's some links from vsphere provider for reference
Testing (if applicable):
Created ubuntu and bottlerocket nodes with different control plane and worker labels and verified they were added properly
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.