Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tinkerbell taints and labels test #2507

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

abhinavmpandey08
Copy link
Member

Description of changes:
Add e2e test for worker node groups with taints and labels for tinkerbell provider on Ubuntu

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jun 22, 2022
@abhinavmpandey08
Copy link
Member Author

/hold
for #2480

@codecov
Copy link

codecov bot commented Jun 22, 2022

Codecov Report

Merging #2507 (5f3c99b) into main (f83da09) will decrease coverage by 0.04%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #2507      +/-   ##
==========================================
- Coverage   57.17%   57.13%   -0.05%     
==========================================
  Files         310      310              
  Lines       25331    25349      +18     
==========================================
  Hits        14484    14484              
- Misses       9521     9539      +18     
  Partials     1326     1326              
Impacted Files Coverage Δ
internal/pkg/api/tinkerbell.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f83da09...5f3c99b. Read the comment docs.

@gwesterfieldjr
Copy link
Contributor

/approved
/lgtm

@abhinavmpandey08
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavmpandey08
Copy link
Member Author

/unhold

@abhinavmpandey08
Copy link
Member Author

/cherry-pick release-0.10

@eks-distro-pr-bot
Copy link
Contributor

@abhinavmpandey08: once the present PR merges, I will cherry-pick it on top of release-0.10 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-pr-bot
Copy link
Contributor

@abhinavmpandey08: new pull request created: #2525

In response to this:

/cherry-pick release-0.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants