Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(rosetta) Bugs in Python translation #2993

Closed
rix0rrr opened this issue Sep 21, 2021 · 1 comment · Fixed by #3052
Closed

(rosetta) Bugs in Python translation #2993

rix0rrr opened this issue Sep 21, 2021 · 1 comment · Fixed by #3052
Assignees
@rix0rrr
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Sep 21, 2021

🐛 Bug Report

Affected Languages

=== is not translated to ==, but left as === (does not exist in Python)

! is translated to ~, should be not
@rix0rrr rix0rrr added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 21, 2021
@rix0rrr rix0rrr changed the title Bugs in Python Rosetta (rosetta) Bugs in Python translation Sep 21, 2021
@rix0rrr rix0rrr self-assigned this Sep 21, 2021
rix0rrr added a commit that referenced this issue Oct 11, 2021
@rix0rrr
fix(rosetta): fix translation of ! and === operators
d5428fe 
These were translated as `~` and not translated at all, respectively.

Fixes #2993.
@rix0rrr rix0rrr mentioned this issue Oct 11, 2021
Merged
@mergify mergify bot closed this as completed in #3052 Oct 11, 2021
mergify bot pushed a commit that referenced this issue Oct 11, 2021
@rix0rrr
fix(rosetta): fix translation of ! and === operators (#3052)
72b9b98 
These were translated as `~` and not translated at all, respectively.

Fixes #2993.



---

By submitting this pull request, I confirm that my contribution is made under the terms of the [Apache 2.0 license].

[Apache 2.0 license]: https://www.apache.org/licenses/LICENSE-2.0
@github-actions
Copy link
Contributor

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(rosetta): fix translation of ! and === operators aws/jsii
1 participant
@rix0rrr