Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dotnet): missing ? on nullable interface members #1287

Merged
merged 5 commits into from
Feb 25, 2020
Merged

fix(dotnet): missing ? on nullable interface members #1287

merged 5 commits into from
Feb 25, 2020

Commits on Feb 24, 2020

  1. fix(dotnet): missing ? on nullable interface members 

    When interfaces declare nullable members, the code generator erroneously omitted the `?` that denotes it, while generated implementations of the interface would have it, causing compilation failures.

Fixes #1285
    @RomainMuller
    RomainMuller committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    658d2be View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rmuller/fix-dotnet-codegen-issue

    @RomainMuller
    RomainMuller authored Feb 24, 2020
    Configuration menu
    Copy the full SHA
    7166819 View commit details
    Browse the repository at this point in the history

  3. Fixup test expectations in jsii-reflect

    @RomainMuller
    RomainMuller committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    96e5ded View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Merge branch 'master' into rmuller/fix-dotnet-codegen-issue

    @mergify
    mergify[bot] authored Feb 25, 2020
    Configuration menu
    Copy the full SHA
    ad1d7a9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into rmuller/fix-dotnet-codegen-issue

    @mergify
    mergify[bot] authored Feb 25, 2020
    Configuration menu
    Copy the full SHA
    b839cf6 View commit details
    Browse the repository at this point in the history