Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pacmak): illegal static overrides in java & c# #2373

Merged
merged 5 commits into from
Dec 22, 2020

Commits on Dec 21, 2020

  1. fix(pacmak): illegal static overrides in java & c#

    Stop emitting "overrides" in the respecting language idiomatic way for
    static methods and properties (while ES6 supports those, this is not
    true of Java and C#).
    
    In Java, this is mostly getting rid of `@Overrides` on static
    declarations. C# *allows* (but does not require) explicitly hiding the
    parent declaration using the `new` keyword. This was introduced as it
    provides additional safeguards against our generating incorrect code.
    
    Fixes #2358
    RomainMuller committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    db6376d View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2020

  1. Configuration menu
    Copy the full SHA
    1c72511 View commit details
    Browse the repository at this point in the history
  2. update docs, too

    RomainMuller committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    d74f5f6 View commit details
    Browse the repository at this point in the history
  3. fixup test expectations

    RomainMuller committed Dec 22, 2020
    Configuration menu
    Copy the full SHA
    641db86 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    4aaac98 View commit details
    Browse the repository at this point in the history