feat(superchain): $NVM_USE_VERSION selects Node.js version
#2726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We added multiple Node versions into the Superchain image, and made it possible to switch between them using NVM. Doing so would require putting `nvm use 14` at the top of every script that wanted to run against a newer Node version, and so would require modification to scripts in our branches. Another, more effective, way to configure the Node version is to be able to do it without modifying the scripts themselves, but by specifying it via the runtime environment. In this case, via environment variable that can be set on the Docker environment. The `$NVM_USE_VERSION` environment variable will lead to an implicit execution of `nvm use $NVM_USE_VERSION` at container startup time, if present.
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
RomainMuller
added a commit
that referenced
this pull request
Mar 23, 2021
Includes the following: - Revert "fix(superchain): use entrypoint to set up nvm (#2736)" - This reverts commit 0e247b6. - Revert "feat(superchain): `$NVM_USE_VERSION` selects Node.js version (#2726)" - This reverts commit fb9abf9. - Revert "feat(superchain): install both Node 10 and Node 14 (#2718)" - This reverts commit 3ca97d9.
RomainMuller
added a commit
that referenced
this pull request
Mar 23, 2021
…2737) Includes the following: - Revert "fix(superchain): use entrypoint to set up nvm (#2736)" - This reverts commit 0e247b6. - Revert "feat(superchain): `$NVM_USE_VERSION` selects Node.js version (#2726)" - This reverts commit fb9abf9. - Revert "feat(superchain): install both Node 10 and Node 14 (#2718)" - This reverts commit 3ca97d9.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We added multiple Node versions into the Superchain image, and made it
possible to switch between them using NVM.
Doing so would require putting
nvm use 14at the top of every scriptthat wanted to run against a newer Node version, and so would require
modification to scripts in our branches.
Another, more effective, way to configure the Node version is to be able
to do it without modifying the scripts themselves, but by specifying it
via the runtime environment. In this case, via environment variable that
can be set on the Docker environment.
The
$NVM_USE_VERSIONenvironment variable will lead to an implicitexecution of
nvm use $NVM_USE_VERSIONat container startup time, ifpresent.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.