Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(superchain): use entrypoint to set up nvm #2736

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

RomainMuller
Copy link
Contributor

@RomainMuller RomainMuller commented Mar 23, 2021

This ensures node is always in the PATH at the start of a container (unless
the user replaced the entrypoint). This attempts to minimize overhead of the
overall setup by using exec in the run.sh script.

Fixes #2734


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

This ensures node is always in the PATH at the start of a container (unless
the user replaced the entrypoint). This attempts to minimize overhead of the
overall setup by using exec in the run.sh script.
@RomainMuller RomainMuller self-assigned this Mar 23, 2021
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 23, 2021
superchain/run.sh Outdated Show resolved Hide resolved
@RomainMuller RomainMuller merged commit 0e247b6 into main Mar 23, 2021
@RomainMuller RomainMuller deleted the rmuller/superchain branch March 23, 2021 10:30
RomainMuller added a commit that referenced this pull request Mar 23, 2021
Includes the following:
- Revert "fix(superchain): use entrypoint to set up nvm (#2736)"
  - This reverts commit 0e247b6.
- Revert "feat(superchain): `$NVM_USE_VERSION` selects Node.js version (#2726)"
  - This reverts commit fb9abf9.
- Revert "feat(superchain): install both Node 10 and Node 14 (#2718)"
  - This reverts commit 3ca97d9.
RomainMuller added a commit that referenced this pull request Mar 23, 2021
…2737)

Includes the following:
- Revert "fix(superchain): use entrypoint to set up nvm (#2736)"
  - This reverts commit 0e247b6.
- Revert "feat(superchain): `$NVM_USE_VERSION` selects Node.js version (#2726)"
  - This reverts commit fb9abf9.
- Revert "feat(superchain): install both Node 10 and Node 14 (#2718)"
  - This reverts commit 3ca97d9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No access to NodeJS in jsii/superchain when overriding the default container image command
2 participants