fix(rosetta): arrays aren't handled properly #3098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces many fixes to array handling: - Array index (`array[5]`) was not supported. - Array types weren't being rendered properly (they were being rendered as the named type `Array` instead of, say, `string[]`). - Functions with variable length arguments were not being marked as varargs, simply saying the parameter type was an `Array`.
kaizencc
approved these changes
Oct 27, 2021
|
Thank you for contributing! ❤️ I will now look into making sure the PR is up-to-date, then proceed to try and merge it! |
|
Merging (with squash)... |
|
Merging (with squash)... |
|
Merging (with squash)... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces many fixes to array handling:
array[5]) was not supported.as the named type
Arrayinstead of, say,string[]).varargs, simply saying the parameter type was an
Array.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.