Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(rosetta): arrays aren't handled properly #3098

Merged
merged 3 commits into from
Oct 27, 2021
Merged

fix(rosetta): arrays aren't handled properly #3098

merged 3 commits into from
Oct 27, 2021

Commits on Oct 27, 2021

  1. fix(rosetta): arrays aren't handled properly 

    This PR introduces many fixes to array handling:

- Array index (`array[5]`) was not supported.
- Array types weren't being rendered properly (they were being rendered
  as the named type `Array` instead of, say, `string[]`).
- Functions with variable length arguments were not being marked as
  varargs, simply saying the parameter type was an `Array`.
    @rix0rrr
    rix0rrr committed Oct 27, 2021
    Configuration menu
    Copy the full SHA
    a758945 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into huijbers/rosetta-arrays

    @mergify
    mergify[bot] authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    ad9c93f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into huijbers/rosetta-arrays

    @mergify
    mergify[bot] authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    5b204a5 View commit details
    Browse the repository at this point in the history