Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: exit with non-zero exit code if there are compilation errors #442

Merged
merged 1 commit into from
Apr 8, 2019
Merged

fix: exit with non-zero exit code if there are compilation errors #442

merged 1 commit into from
Apr 8, 2019

Commits on Apr 8, 2019

  1. fix: exit with non-zero exit code if there are compilation errors 

    In #383 we modified the compiler to continue jsii validation despite
compilation errors but did not propagate the fact that there were
compilation errors.

This resulted in "jsii" exiting with a 0 exit code even in case
of errors.

Fixes #441
    Elad Ben-Israel committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    7a62197 View commit details
    Browse the repository at this point in the history