Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry-pick(0.34.x): fix: ensure alias version isn't dropped round-trip (#6777) #7001

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Sep 12, 2024

Fixes #N/A

Description
Cherry picks #6777

How was this change tested?

Does this change impact docs?

  • Yes, PR includes docs updates
  • Yes, issue opened: #
  • No

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jmdeal jmdeal requested a review from a team as a code owner September 12, 2024 21:40
@jmdeal jmdeal requested a review from tzneal September 12, 2024 21:40
jonathan-innis
jonathan-innis previously approved these changes Sep 13, 2024
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10945434714

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 77.45%

Totals Coverage Status
Change from base Build 10932327894: 0.1%
Covered Lines: 5413
Relevant Lines: 6989

💛 - Coveralls

@jmdeal jmdeal merged commit 85a0b2a into aws:release-v0.34.x Sep 23, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants