Skip to content

fix(s2n-quic-dc): include ipv6 header length in MAX_TOTAL_IPV6 payload length #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
Merged

fix(s2n-quic-dc): include ipv6 header length in MAX_TOTAL_IPV6 payload length #2727

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9f74ded
fix(test): include ipv6 header length in max_total_test calculation
boquan-fang Jul 25, 2025
86964bb
address PR comments:
boquan-fang Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dc/s2n-quic-dc/src/msg/segment.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ const MAX_TOTAL_IPV4: u16 = if cfg!(target_os = "linux") {

/// The maximum payload allowed in sendmsg calls using IPv6+UDP
const MAX_TOTAL_IPV6: u16 = if cfg!(target_os = "linux") {
// IPv6 doesn't include the IP header size in the calculation
u16::MAX - UDP_HEADER_LEN
// The IPV6_HEADER_LEN is required in this calculation to accommodate older kernels (such as kernel 5.10)
u16::MAX - IPV6_HEADER_LEN - UDP_HEADER_LEN
} else {
9001 - IPV6_HEADER_LEN - UDP_HEADER_LEN
};
Expand Down
Loading