Update inbound-ses-spam-filter to include Lambda ARN#1294
Merged
keetonian merged 1 commit intoaws:developfrom Dec 6, 2019
Merged
Update inbound-ses-spam-filter to include Lambda ARN#1294keetonian merged 1 commit intoaws:developfrom
keetonian merged 1 commit intoaws:developfrom
Conversation
dballance
changed the title
5 tasks
Codecov Report
@@ Coverage Diff @@
## develop #1294 +/- ##
=======================================
Coverage 94.5% 94.5%
=======================================
Files 72 72
Lines 3746 3746
Branches 742 742
=======================================
Hits 3540 3540
Misses 104 104
Partials 102 102Continue to review full report at Codecov.
|
ShreyaGangishetty
approved these changes
Dec 5, 2019
keetonian
approved these changes
Dec 6, 2019
Contributor
|
Thank you for contributing this fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Currently, this filter is pretty useless to deploy as a nested stack. I cannot use the published resource because I cannot tie the Function ARN to my SES ReceiptRuleAction. This change adds an output so that this template is useful for nested deployments.
Description of how you validated changes: No validation
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.