Update inbound-ses-spam-filter to include Fn ARN#1289
Closed
dballance wants to merge 8 commits intoaws:developfrom
Closed
Update inbound-ses-spam-filter to include Fn ARN#1289dballance wants to merge 8 commits intoaws:developfrom
dballance wants to merge 8 commits intoaws:developfrom
Conversation
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jonschlinkert/mixin-deep/releases) - [Commits](jonschlinkert/mixin-deep@1.3.1...1.3.2) Signed-off-by: dependabot[bot] <support@github.com>
feat: changes for eventbusname on cloudwatch event (aws#1185)
Currently, this filter is pretty useless to deploy as a nested stack. I cannot use the [published resource](https://serverlessrepo.aws.amazon.com/applications/arn:aws:serverlessrepo:us-east-1:077246666028:applications~inbound-ses-spam-filter) because I cannot tie the Function ARN to my SES ReceiptRuleAction.
Codecov Report
@@ Coverage Diff @@
## master #1289 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 71 71
Lines 3630 3630
Branches 717 717
=======================================
Hits 3428 3428
Misses 103 103
Partials 99 99Continue to review full report at Codecov.
|
|
@dballance Could you please fix the merge conflicts and resubmit this PR? |
Contributor
Author
|
I may just purge this PR and make the change on develop. I didn't make any of the changes except a single change to the template in this example. |
Contributor
Author
|
Abandoning in favor of #1294 |
|
@dballance Thank you. I will review #1294 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes: Currently, this filter is pretty useless to deploy as a nested stack. I cannot use the published resource because I cannot tie the Function ARN to my SES ReceiptRuleAction. This change adds an output so that this template is useful for nested deployments.
Description of how you validated changes: No validation
Checklist:
make prpassesexamples/2016-10-31By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.