Fix unintended limitation with fetching APIs #393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
requested review from
etsung-aws,
jiyou95,
MynockSpit and
skylarbemus
as code owners
etsung-aws
reviewed
May 15, 2020
| }).promise() | ||
| const apis = restApiResult.items | ||
|
|
||
| if (restApiResult.position != null) { |
There was a problem hiding this comment.
want while instead of if?
etsung-aws
approved these changes
May 15, 2020
MynockSpit
approved these changes
May 15, 2020
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes: Instead of just requesting it blindly, we now loop to ensure we get every API.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.