Updating apis call to overcome the 25 limit #422
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, due to default limit of 25, getRestAPis is getting only 25 APIs and even with usagePlan fix awslabs#257 does not show all the apis in the portal because usageplan APIs are filtered with apis list. Hence add this will help query a larger limit.
jinman
requested review from
etsung-aws,
jiyou95,
MynockSpit and
skylarbemus
as code owners
|
Fixed in #393 and released in v4.0.0. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, due to default limit of 25, getRestAPis is getting only 25 APIs and even with usagePlan fix #257 does not show all the apis in the portal because usageplan APIs are filtered with apis list. Hence add this will help query a larger limit.
Issue #, if available:
#418 We are unable to see all the APIs in the AdminPortal due to the default 25 limit. As a result, even if the APIs are listed under the usagePlan (fix for #257), it is not shown because they are being filtered.
Description of changes:
Just changed the visibility to iterate over the pagination to get the full list when GetRestApis is called.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.