Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

a JVM leak that we cannot detected #362

Merged
merged 3 commits into from
Aug 2, 2021
Merged

a JVM leak that we cannot detected #362

merged 3 commits into from
Aug 2, 2021

Conversation

TingDaoK
Copy link
Contributor

@TingDaoK TingDaoK commented Aug 2, 2021 •
edited
Loading

Issue #, if available:

  • The local variable created JVM thread from C thread will not be able to cleaned up automatically. We HAVE to clean it up by ourselves.
  • Our memory leak check CANNOT track the memory allocated by JVM. So, it's not caught by us.

Description of changes:

  • Clean up the local reference of jbyteArray at the end of callback

TODO

  • We need to check JVM as well. MAKE sure not only the native code has no leak, but also JVM is leak-free.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@TingDaoK TingDaoK merged commit 9573ef3 into main Aug 2, 2021
@TingDaoK TingDaoK deleted the jni_leak branch August 2, 2021 23:11
@waahm7 waahm7 mentioned this pull request Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinboswell justinboswell justinboswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TingDaoK @justinboswell