Fix Memory Leaks #734
Merged
Fix Memory Leaks #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TingDaoK
reviewed
Dec 13, 2023
src/native/credentials.c
Outdated
| @@ -73,6 +73,10 @@ struct aws_credentials *aws_credentials_new_from_java_credentials(JNIEnv *env, j | |||
| aws_jni_byte_cursor_from_jbyteArray_release(env, session_token, session_token_cursor); | |||
| } | |||
|
|
|||
| (*env)->DeleteLocalRef(env, access_key_id); | |||
There was a problem hiding this comment.
Do we need to check for NULL?
There was a problem hiding this comment.
I would like to have one place to clean things up even if we error out earlier.
There was a problem hiding this comment.
Also, add a comment here
Suggested change
| (*env)->DeleteLocalRef(env, access_key_id); | |
| /* When the local reference created by a thread from C, JVM will not be able to clean it up automatically. */ |
There was a problem hiding this comment.
According to https://docs.oracle.com/en/java/javase/11/docs/specs/jni/functions.html, yes null is alowed.
There was a problem hiding this comment.
I modified it to check for null, ensuring consistency, and added a block for clean-up. I didn't move the cursor clean-up as it makes the code messier.
TingDaoK
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
See #362. JVM fails to create local references created by C threads.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.