fix free-bsd CI #579
Merged
fix free-bsd CI #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graebm
approved these changes
Jul 10, 2024
| @@ -232,7 +232,7 @@ jobs: | |||
| shell: bash | |||
| environment_variables: AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY AWS_DEFAULT_REGION AWS_REGION | |||
| run: | | |||
| sudo pkg install -y python3 py39-urllib3 py39-pip py39-awscli cmake | |||
| sudo pkg install -y python3 devel/py-pip net/py-urllib3 devel/py-awscli cmake | |||
There was a problem hiding this comment.
did install python3 change from being 3.9 to 3.11?
does python3 point to whatever is "latest"? and like devel/py-pip points to whatever is "latest"?
If so, this seems fine
There was a problem hiding this comment.
not sure if they just updated recently or not. but the current default version for python is 3.11 https://cgit.freebsd.org/ports/tree/Mk/bsd.default-versions.mk#n139
https://wiki.freebsd.org/Python looks like they will use the default version for all the python packages.
There was a problem hiding this comment.
freebsd/freebsd-ports@62a23ef oh, it was updated 2 month ago.
This was referenced Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
pkg install devel/py-pip. https://www.freshports.org/devel/py-pip/pkg install net/py-urllib3. https://www.freshports.org/net/py-urllib3/pkg install devel/py-awscli. https://www.freshports.org/devel/py-awscli/By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.