Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix free-bsd CI #579

Merged
merged 6 commits into from
Jul 10, 2024
Merged

fix free-bsd CI #579

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
210017f
test-ci
TingDaoK Jul 9, 2024
678dfae
without version?
TingDaoK Jul 9, 2024
11bf036
devel?
TingDaoK Jul 9, 2024
184d9f4
category?
TingDaoK Jul 9, 2024
d1e8066
:)
TingDaoK Jul 9, 2024
2f496ab
:) whyyyyyyy
TingDaoK Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ jobs:
shell: bash
environment_variables: AWS_ACCESS_KEY_ID AWS_SECRET_ACCESS_KEY AWS_DEFAULT_REGION AWS_REGION
run: |
sudo pkg install -y python3 py39-urllib3 py39-pip py39-awscli cmake
sudo pkg install -y python3 devel/py-pip net/py-urllib3 devel/py-awscli cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did install python3 change from being 3.9 to 3.11?

does python3 point to whatever is "latest"? and like devel/py-pip points to whatever is "latest"?

If so, this seems fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if they just updated recently or not. but the current default version for python is 3.11 https://cgit.freebsd.org/ports/tree/Mk/bsd.default-versions.mk#n139

https://wiki.freebsd.org/Python looks like they will use the default version for all the python packages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

freebsd/freebsd-ports@62a23ef oh, it was updated 2 month ago.

python3 -c "from urllib.request import urlretrieve; urlretrieve('${{ env.BUILDER_HOST }}/${{ env.BUILDER_SOURCE }}/${{ env.BUILDER_VERSION }}/builder.pyz', 'builder')"
chmod a+x builder
./builder build -p ${{ env.PACKAGE_NAME }}
Expand Down
Loading