Add OpenTelemetry layer as optional #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Calavera <david.calavera@gmail.com>
bnusunny
approved these changes
Jun 26, 2024
Oliboy50
reviewed
Jun 26, 2024
Comment on lines
+76
to
+78
| // Enter the span before calling the inner service | ||
| // to ensure that it's assigned as parent of the inner spans. | ||
| let _guard = span.enter(); |
There was a problem hiding this comment.
I didn't know that using .instrument(span) was not enough when calling a future (or maybe it's only useful in a "inner service" context?), where did you find docs about that?
And since the span is entered before starting to poll the future, it will increase the span duration, right?
Oliboy50
reviewed
Jun 26, 2024
There was a problem hiding this comment.
line 67:
{ traceconv::FAAS_TRIGGER } = "http",
I think it should be configurable because the lambda_runtime crate can be used without using HTTP triggers (it could defaults to http when using the lambda_http crate though)
There was a problem hiding this comment.
that sounds like a good idea. Feel free to open a PR with improvements
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #866
Description of changes:
By submitting this pull request