Compile the canary against musl #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rcoh
approved these changes
Nov 7, 2022
The success check is fixed in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the canary.
I'm not really sure how it succeeded before since it wasn't compiling against musl. Perhaps it was a coincidence between the Ubuntu version the Lambda compiled on, and the Amazon Linux 2 version it ran on. This PR makes it compile against musl and overrides the
rust-toolchain.ymlfile in smithy-rs so that the correct toolchain version is used.Successful canary run: https://github.com/awslabs/aws-sdk-rust/actions/runs/3414713195/jobs/5683095244
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.