Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix canary Lambda invoke success check #1960

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

jdisanti
Copy link
Collaborator

@jdisanti jdisanti commented Nov 8, 2022

Motivation and Context

It seems Lambda's Invoke returns a status 200 even when the function fails with exit status 1, but at the same time, it responds with function_error set. I tested this by uploading a trivial Rust binary that just exits with status 1 to Lambda and invoking it, which resulted in:

[src/main.rs:18] result = Ok(
    InvokeOutput {
        status_code: 200,
        function_error: Some(
            "Unhandled",
        ),
        // -- snip --
    },
)

This PR fixes the check in canary-runner.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@Velfi Velfi enabled auto-merge (squash) November 8, 2022 15:33
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

A new generated diff is ready to view.

A new doc preview is ready to view.

@Velfi Velfi merged commit 55a66a2 into main Nov 8, 2022
@Velfi Velfi deleted the jdisanti-canary-invoke-check branch November 8, 2022 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants