Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint: freeze & run Black version 24.02 #3131

Merged
merged 13 commits into from
Apr 5, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Feb 20, 2024

Issue #, if available:
set a single black version to ensure reproducibility
UPDATE: seem that the latest Black would need to be applied

Description of changes:
freeze Black version, but the better way is in #3111

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

cc: @jaheba @kashif @lostella

@Borda Borda changed the title lint: run Black lint: freeze Black version 24.01 Feb 20, 2024
@Borda
Copy link
Contributor Author

Borda commented Feb 20, 2024

@jaheba @kashif @lostella all it is generated by Blck, but maybe you will feel more confident running/applying it on your own... 🦩

@Borda Borda changed the title lint: freeze Black version 24.01 lint: freeze & run Black version 24.01 Feb 20, 2024
@Borda
Copy link
Contributor Author

Borda commented Feb 20, 2024

This test is failing but only on py3.8 so it is strange and maybe flaky?
FAILED test/mx/model/deep_factor/test_model.py::test_accuracy[constant-True] - assert 0.3266171349419488 <= 0.3

@lostella
Copy link
Contributor

Flaky test

@Borda
Copy link
Contributor Author

Borda commented Feb 22, 2024

Flaky test

playing with flaky over here: #3132

.github/workflows/style_type_checks.yml Show resolved Hide resolved
.github/workflows/style_type_checks.yml Outdated Show resolved Hide resolved
@Borda Borda requested a review from lostella February 22, 2024 21:13
@Borda
Copy link
Contributor Author

Borda commented Feb 26, 2024

@lostella mind checking it again, pls 🐿️
all seems to be 🟢

@Borda Borda changed the title lint: freeze & run Black version 24.01 lint: freeze & run Black version 24.02 Feb 27, 2024
@Borda
Copy link
Contributor Author

Borda commented Mar 19, 2024

@lostella, if you would have a chance to check it, it would be great to finish it 🦩

@Borda
Copy link
Contributor Author

Borda commented Mar 31, 2024

@lostella, is there still anything I need to change? 🐿️

@lostella
Copy link
Contributor

lostella commented Apr 5, 2024

@Borda maybe it's better not to freeze the black version. For example, vulnerabilities are found in black versions prior to 24.3.0, see https://github.com/awslabs/gluonts/security/dependabot/17

@Borda
Copy link
Contributor Author

Borda commented Apr 5, 2024

@lostella I see your point but from developer's perspective it is easier to have it frozen so you won't si sudden changes or broken lint, which would be unrelated to a contributor work, but instead move the black version to requorements/lint.txt and dependable which would periodically check and bump via PR so you will have it still up-to-date but fully under control... :) if you want I can do that in another PR :)

@lostella
Copy link
Contributor

lostella commented Apr 5, 2024

but instead move the black version to requorements/lint.txt and dependable which would periodically check and bump via PR so you will have it still up-to-date but fully under control

yes, I think that would be much better!

@Borda
Copy link
Contributor Author

Borda commented Apr 5, 2024

yes, I think that would be much better!

OK so, could we please land this with just update and I will prepare another with the automated process so it is separately and easier to review...

@lostella lostella merged commit 61133ef into awslabs:dev Apr 5, 2024
19 checks passed
@Borda Borda deleted the fix/black branch April 5, 2024 13:34
@Borda
Copy link
Contributor Author

Borda commented Apr 5, 2024

@lostella in fact this pre-commit if the bot is installed can do this version check and update, see: #3111

kashif pushed a commit to kashif/gluon-ts that referenced this pull request Jun 15, 2024
*Issue #, if available:*
set a single black version to ensure reproducibility
UPDATE: seem that the latest Black would need to be applied

*Description of changes:*
freeze Black version, but the better way is in awslabs#3111


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.


**Please tag this pr with at least one of these labels to make our
release process faster:** BREAKING, new feature, bug fix, other change,
dev setup

cc: @jaheba @kashif @lostella
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants