Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unify using @pytest.mark.flaky(...) & bump pytest plugins #3132

Merged
merged 25 commits into from
Mar 4, 2024

Conversation

Borda
Copy link
Contributor

@Borda Borda commented Feb 21, 2024

Issue #, if available:

Description of changes:
seem that there is mix of few packages and maybe better to use just pytest extension

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Please tag this pr with at least one of these labels to make our release process faster: BREAKING, new feature, bug fix, other change, dev setup

cc: @lostella

@Borda
Copy link
Contributor Author

Borda commented Feb 21, 2024

switching to pytest-rerunfailures for py3.8 support and messing with some other stuff

@Borda Borda marked this pull request as draft February 21, 2024 10:24
@Borda
Copy link
Contributor Author

Borda commented Feb 22, 2024

following suggestion from pytest-dev/pytest#11052 (comment)

@Borda Borda changed the title test: unify using @pytest.mark.flaky(...) test: unify using @pytest.mark.flaky(...) & bump pytest plugins Feb 22, 2024
@Borda Borda marked this pull request as ready for review February 22, 2024 20:41
.github/workflows/mxnet_nightly.yml Show resolved Hide resolved
requirements/requirements-test.txt Outdated Show resolved Hide resolved
requirements/requirements-test.txt Outdated Show resolved Hide resolved
holidays~=0.9
matplotlib~=3.6
holidays >=0.9
matplotlib >=3.6, <3.7
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~=3.6?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had some problem with it and ~ is conda notation not pip

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do you want me to use ~ for all?

test/mx/distribution/test_mx_distribution_inference.py Outdated Show resolved Hide resolved
@Borda Borda requested a review from lostella February 22, 2024 21:14
@Borda
Copy link
Contributor Author

Borda commented Feb 26, 2024

@lostella, it seems like seeding tests also help to gain some stability...

Copy link
Contributor

@lostella lostella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Borda I suggest to revert two changes (see inline proposed changes). In general, keeping PRs scoped to a small set of changes makes it easier to review, approve & merge faster

Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
@Borda Borda requested a review from lostella March 2, 2024 11:26
Borda and others added 3 commits March 2, 2024 12:26
Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
@Borda
Copy link
Contributor Author

Borda commented Mar 4, 2024

@lostella seems all tests are 🟢

@lostella lostella added CI This item concerns continuous integration tests This item concerns improving tests labels Mar 4, 2024
@lostella lostella merged commit 5314021 into awslabs:dev Mar 4, 2024
19 checks passed
kashif pushed a commit to kashif/gluon-ts that referenced this pull request Jun 15, 2024
…slabs#3132)

*Issue #, if available:*

*Description of changes:*
seem that there is mix of few packages and maybe better to use just
`pytest` extension


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.


**Please tag this pr with at least one of these labels to make our
release process faster:** BREAKING, new feature, bug fix, other change,
dev setup

cc: @lostella

---------

Co-authored-by: Lorenzo Stella <lorenzostella@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI This item concerns continuous integration tests This item concerns improving tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants