Commits on Mar 16, 2023

1. Move KFP SageMaker test (awslabs#618) …

   **Which issue is resolved by this Pull Request:**
   Resolves #
   
   **Description of your changes:**
   KFP SageMaker test is unnecessary in port_forward_sanity and causing
   flakey issues, while we diagonse those will move it to test_sanity.py
   
   **Testing:**
   - [ ] Unit tests pass
   - [ ] e2e tests pass
   - Details about new tests (If this PR adds a new feature)
   - Details about any manual tests performed
   
   By submitting this pull request, I confirm that my contribution is made
   under the terms of the Apache 2.0 license.

   

   ryansteakley committed Mar 16, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for f96eda4
   • Browse repository at this point

   Copy the full SHA

   f96eda4 View commit details

   Browse the repository at this point in the history

2. Cleanup ACK add try/except for detaching policy (awslabs#577) …

   **Description of your changes:**
   Cleanup may fail in edge-case where the policy was already
   deleted/detached before the clean-up was run. In this case the role will
   never be deleted. Then in future runs of ACK creation in that same
   account it would not create the role again, thus the role would have a
   missing policy and be unable to run SM jobs
   
   **Testing:**
   - [ ] Unit tests pass
   - [ ] e2e tests pass
   - Details about new tests (If this PR adds a new feature)
   - Details about any manual tests performed
   
   By submitting this pull request, I confirm that my contribution is made
   under the terms of the Apache 2.0 license.

   

   ryansteakley committed Mar 16, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 1959452
   • Browse repository at this point

   Copy the full SHA

   1959452 View commit details

   Browse the repository at this point in the history