[Cherry-pick] Blueprints v4.31.0 (#731) and auto setup describe ALB name fix (#732) #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…labs#731) - Updated the EKS Blueprints module version in use to v4.31, which contains the updated permissions fix for the EFS CSI driver to work correctly with Kubeflow. Details [here](aws-ia/terraform-aws-eks-blueprints#1581). - Added the `--skip-driver-installation` flag to the EFS auto setup script as a temporary workaround for the missing full Terraform EFS add-on support By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
…abs#732) Currently the ALB name is extracted from the ALB DNS. For internal scheme ALBs the DNS contains a `internal-` prefix that is not part of the ALB name. The changes in this PR strip `internal-` from the front of the DNS name. ALB validation prevents ALBs with `internal-` as a prefix from being created. By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
surajkota
approved these changes
May 11, 2023
ryansteakley
approved these changes
May 11, 2023
|
let me cut new release branch and we can pick this PR to that to keep the code and docs in sync |
surajkota
changed the base branch from
release-v1.7.0-aws-b1.0.0
to
release-v1.7.0-aws-b1.0.1
|
done, release-v1.7.0-aws-b1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick #731 #732
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.