-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add client customizer interface for each supported integration. #1229
Conversation
@@ -254,6 +254,33 @@ The Spring Boot Starter for S3 provides the following configuration options: | |||
| `spring.cloud.aws.s3.transfer-manager.follow-symbolic-links` | Specifies whether to follow symbolic links when traversing the file tree in `S3TransferManager#uploadDirectory` operation | No | `null` (falls back to SDK default) | |||
|=== | |||
|
|||
=== Client Customization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this looks fine, similar docs will be added to each integration.
* {@link #configureSyncClient(AwsClientBuilder, AwsClientProperties, AwsConnectionDetails, Stream, Stream)}. | ||
*/ | ||
@Deprecated | ||
public <T extends AwsClientBuilder<T, ?>> T configureSyncClient(T builder, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for the backward compatibility these methods must be added, but they are marked as deprecated to prevent users from using them in the new code.
Really like the idea. Will follow up with detail Review but idea as it is I love it much better user experience |
@maciejwalkowiak reviewed good to go! |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Fixes #562
DynamoDbClientBuilder
user must define one or moreDynamoDbClientCustomizer
@Order
is taken into consideration when applying customizationCommonAwsSyncClientCustomizer
(for sync) orCommonAwsAsyncClientCustomizer
(for async) beans.Example: