Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: Make AwsClientCustomizer Flexible #758

Closed
wants to merge 2 commits into from

Conversation

MatejNedic
Copy link
Member

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

💡 Motivation and Context

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated reference documentation to reflect the change
  • All tests passing
  • No breaking changes

🔮 Next steps

@github-actions github-actions bot added component: core Core functionality related issue component: sns SNS integration related issue labels Apr 5, 2023
@MatejNedic
Copy link
Member Author

MatejNedic commented Apr 5, 2023

I still need to add more tests and documentation want to first talk about whether are there ways how we can improve and make customization even simpler.

@MatejNedic MatejNedic changed the title Make AwsClientCustomizer Flexible Draft: Make AwsClientCustomizer Flexible Apr 5, 2023
@@ -34,6 +36,11 @@ default ClientOverrideConfiguration overrideConfiguration() {
return null;
}

@Nullable
default ClientOverrideConfiguration.Builder overrideConfigurationBuilder() {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maciejwalkowiak I was thinking and checking if we can parameterize this somehow through properties. Tbh I am not seeing a clean way to do it, there are just too many options, and some of them you can't even describe in properties.
Maybe we can support just some simple ones as

    private final Duration apiCallAttemptTimeout;
    private final Duration apiCallTimeout;

and apply them in the builder if not null. If not we don't apply to the builder anything besides our applyUserAgent.

@MatejNedic
Copy link
Member Author

Closed in favour of #1229

@MatejNedic MatejNedic closed this Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: core Core functionality related issue component: sns SNS integration related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant