tests: enable brew style in linters
#1354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
force-pushed
the
homebrew_style_lint_tests
branch
from
ac24009
to
8850722
Compare
|
Removed the restyled copies from the snapshots. It broke Linux and Windows, which don't have the ability to run |
mistydemeo
force-pushed
the
homebrew_style_lint_tests
branch
from
8850722
to
d8130cf
Compare
This adds a `brew style` linter to make sure that our generated Homebrew formulas will pass Homebrew's `brew style` for users who have enabled Homebrew's default CI setup for their taps. I've also ensured our snapshots contain the auto-restyled copies after `brew style --fix` is run. This required one stylistic change: the hashmap for binary aliases would violate the line length lint, and unfortunately Rubocop's line length autoformatter was consistently getting the formatting wrong. This instead (ab)uses the fact that JSON hashmaps have a compatible syntax to Ruby 1.9+ hashmaps so long as symbols are the keys - and we were already using symbolized keys. The resulting hashmap is slightly strange-looking by Ruby standards, since symbolized keys usually aren't quoted, but Rubocop isn't mad about it.
mistydemeo
force-pushed
the
homebrew_style_lint_tests
branch
3 times, most recently
from
6d7a8d8
to
bcfd4a2
Compare
Gankra
approved these changes
Aug 21, 2024
mistydemeo
force-pushed
the
homebrew_style_lint_tests
branch
from
bcfd4a2
to
7621c03
Compare
mistydemeo
force-pushed
the
homebrew_style_lint_tests
branch
from
7621c03
to
ea8ec8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
brew stylelinter to make sure that our generated Homebrew formulas will pass Homebrew'sbrew stylefor users who have enabled Homebrew's default CI setup for their taps.I've also ensured our snapshots contain the auto-restyled copies afterbrew style --fixis run.This required one stylistic change: the hashmap for binary aliases would violate the line length lint, and unfortunately Rubocop's line length autoformatter was consistently getting the formatting wrong. This instead (ab)uses the fact that JSON hashmaps have a compatible syntax to Ruby 1.9+ hashmaps so long as symbols are the keys - and we were already using symbolized keys. We can therefore use jinja's
tojsonwith an indent to enable pretty-printing.