Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes last eos token not in labels on basic use case #2287

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fixes last eos token not in labels on basic use case #2287

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
94c226e
fixes last eos token not in labels on basic use case
winglian Jan 24, 2025
6c49083
improve check for base case
winglian Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/axolotl/prompt_strategies/chat_template.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ def messages(self, messages):
def tokenize_prompt(self, prompt):
# Old simple legacy behavior that works reliably.
if (
not self.roles_to_train
(not self.roles_to_train or self.roles_to_train == ["assistant"])
and not self.train_on_eos
and not self.prompter.message_field_training
and not self.prompter.message_field_training_detail
Expand Down
Loading