Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect usage of Makefile since #1416 #1419

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

yangby-cryptape
Copy link
Collaborator

@yangby-cryptape yangby-cryptape commented Sep 11, 2023

What this PR does / why we need it?

This PR fix an incorrect usage of Makefile introduced since #1416.

The target-specific variable values are not applied in the environment directly, they have to be passed via a explicit set, except the variables which used in built-in target rules.

👉 A simple example to explain this rule and the exception. (useful)
  • A simple Makefile:

    aaa:
            @true && WIIL_BE_SET="$(WIIL_BE_SET)" ./check-env
    
    bbb: WIIL_BE_SET=true
    bbb: WONT_BE_SET=true
    bbb: aaa
    
    # The variables which used in built-in target rules don't require a explicit set.
    # When users execute `make build`, `CFLAGS = -g` will be applied.
    a.o: a.c
    build: CFLAGS = -g
    build: a.o
    clean:
            rm *.o
  • A simple bash script check-env:

    #!/usr/bin/env bash
    
    echo "will_be_set = [${WIIL_BE_SET}]"
    echo "wont_be_set = [${WONT_BE_SET}]"
  • The result of tests:

    > make aaa
    will_be_set = []
    wont_be_set = []
    > make bbb
    will_be_set = [true]
    wont_be_set = []
    > make clean a.o
    cc    -c -o a.o a.c
    > make clean build
    cc -g    -c -o a.o a.c
    

References:

What is the impact of this PR?

No Breaking Change

CI Settings

CI Usage

Tip: Check the CI you want to run below, and then comment /run-ci.

CI Switch

  • E2E Tests
  • Web3 Compatible Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests

CI Description

CI Name Description
Chaos CI Test the liveness and robustness of Axon under terrible network condition
Cargo Clippy Run cargo clippy --all --all-targets --all-features
Coverage Test Get the unit test coverage report
E2E Test Run end-to-end test to check interfaces
Code Format Run cargo +nightly fmt --all -- --check and cargo sort -gwc
Web3 Compatible Test Test the Web3 compatibility of Axon
v3 Core Test Run the compatibility tests provided by Uniswap V3
OCT 1-5 | 6-10 | 11 | 12-15 | 16-19 Run the compatibility tests provided by OpenZeppelin

@yangby-cryptape

This comment was marked as off-topic.

@github-actions
Copy link

CI tests run on commit:

CI test list:

  • E2E Tests
  • OCT 1-5 And 12-15
  • OCT 6-10
  • OCT 11
  • OCT 16-19
  • v3 Core Tests
  • Web3 Compatible Tests

Please check ci test results later.

@Flouse Flouse requested review from a team, blckngm and wenyuanhust and removed request for a team September 11, 2023 15:45
@Flouse Flouse merged commit 508c72c into main Sep 12, 2023
@yangby-cryptape yangby-cryptape deleted the yangby/bugfix/incorrect-makefile-usage branch September 12, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants