This repository has been archived by the owner on Aug 31, 2018. It is now read-only.
ci: add macos to CI #63
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkrems
reviewed
Sep 18, 2017
test/parallel/test-v8-serdes.js
Outdated
| @@ -63,7 +65,7 @@ const deserializerTypeError = | |||
| { | |||
| const ser = new v8.DefaultSerializer(); | |||
| ser._writeHostObject = common.mustCall((object) => { | |||
| assert.strictEqual(object, process.stdin._handle); | |||
| assert.strictEqual(object, hostObject); | |||
| const buf = Buffer.from('stdin'); | |||
There was a problem hiding this comment.
[Curiosity / context question]: I assume that in the context of this test, "stdin" is meant to be just a random string constant. Would it be less confusing to change it to something like "hostObjectTag" or similar after this change? Or are you trying to keep the churn minimal?
There was a problem hiding this comment.
No, I just did search/replace, that’s all. ;) Thanks for catching is, updated!
If `stdin` was closed or referred to a file, this didn't work, because it was accessed via file descriptor. Instead, use another generic native object.
jkrems
approved these changes
Sep 18, 2017
Fishrock123
reviewed
Sep 18, 2017
| @@ -20,6 +20,8 @@ const objects = [ | |||
| circular | |||
| ]; | |||
|
|
|||
| const hostObject = new (process.binding('js_stream').JSStream)(); | |||
There was a problem hiding this comment.
🤔 I thought this exploded last time I tried it.
There was a problem hiding this comment.
You mean, constructing a JSStream like that? It seems to work fine to me
Fishrock123
approved these changes
Sep 18, 2017
addaleax
added a commit
that referenced
this pull request
Sep 18, 2017
If `stdin` was closed or referred to a file, this didn't work, because it was accessed via file descriptor. Instead, use another generic native object. PR-URL: #63 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax
added a commit
that referenced
this pull request
Sep 18, 2017
PR-URL: #63 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
danbev
pushed a commit
to danbev/node
that referenced
this pull request
Oct 23, 2017
If `stdin` was closed or referred to a file, this didn't work, because it was accessed via file descriptor. Instead, use another generic native object. cherry-picked from ayojs/ayo#63
2 tasks
danbev
pushed a commit
to danbev/node
that referenced
this pull request
Oct 25, 2017
If `stdin` was closed or referred to a file, this didn't work, because it was accessed via file descriptor. Instead, use another generic native object. cherry-picked from ayojs/ayo#63 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
cjihrig
pushed a commit
to nodejs/node
that referenced
this pull request
Oct 25, 2017
If `stdin` was closed or referred to a file, this didn't work, because it was accessed via file descriptor. Instead, use another generic native object. cherry-picked from ayojs/ayo#63 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
ci