test: make test-v8-serdes work without stdin #16382
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just to mention it: ayojs/ayo@06a1e54 also fixes this but doesn’t require skipping anything … I think that should be fine to use here |
Very nice! Any advice on the the correct procedure for including that so the proper credit and such is given? Thanks |
|
@danbev Since it’s my commit – do whatever you want with it. :) Just cherry-picking it should be fine, but whatever gets you where the code needs to be works for me 😄 |
If `stdin` was closed or referred to a file, this didn't work, because it was accessed via file descriptor. Instead, use another generic native object. cherry-picked from ayojs/ayo#63
danbev
force-pushed
the
test-v8-serdes_handle
branch
from
daefca6
to
d38a427
Compare
danbev
changed the title
cjihrig
approved these changes
Oct 23, 2017
jasnell
approved these changes
Oct 23, 2017
|
Landed in 70670b0 |
apapirovski
referenced
this pull request
Oct 25, 2017
If `stdin` was closed or referred to a file, this didn't work, because it was accessed via file descriptor. Instead, use another generic native object. cherry-picked from ayojs/ayo#63 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
stdinwas closed or referred to a file, this didn't work,because it was accessed via file descriptor.
Instead, use another generic native object.
cherry-picked from ayojs/ayo#63
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test