-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support ESLint 8.x #70
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MichaelDeBoey feels like a duplicate of #69. (mentioned in #68)
Am I wrong?
Codecov Report
@@ Coverage Diff @@
## master #70 +/- ##
============================================
- Coverage 100.00% 82.35% -17.65%
============================================
Files 1 1
Lines 51 51
============================================
- Hits 51 42 -9
- Misses 0 9 +9
Continue to review full report at Codecov.
|
@AdrieanKhisbe Oh sorry, I didn't see that one 😕 This PR is adding some small fixes and updates ESLint dependency of the package too though. |
@MichaelDeBoey, no problem. I just closed #69 as yours is more complete |
Since we use `npm test` in CI and use a separate command for integration tests, we need to make sure `npm test` runs the unit tests.
Thanks for the PR! Since there are no code changes, I am not planning on publishing a new release. Let me know if there are any concerns with that plan! |
ESLint v8.0.0 is released 🎉
devDependency compatibility with ESLint 8:
eslint-config-prettier
(Support ESLint 8.x prettier/eslint-config-prettier#200)Releaseeslint-plugin-prettier
(Support ESLint 8.x prettier/eslint-plugin-prettier#427)ReleaseCloses #68