Fix for following symbolic links, plus start testing things #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the commit I also set up unit testing
|
I also functional tested this by creating a link to a directory and |
b-ryan
added a commit
that referenced
this pull request
Aug 1, 2015
Fix for following symbolic links, plus start testing things
amtrivedi91
added a commit
to amtrivedi91/powerline-shell
that referenced
this pull request
Aug 31, 2016
Fix for following symbolic links, plus start testing things
amtrivedi91
added a commit
to amtrivedi91/powerline-shell
that referenced
this pull request
Aug 31, 2016
Fix for following symbolic links, plus start testing things
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #64.
The comments in #64 and in the code explain the motivation. New tests I added cover the behavior.