Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to not follow symlinks #64

Closed
wants to merge 1 commit into from
Closed

add option to not follow symlinks #64

wants to merge 1 commit into from

Conversation

dbsr
Copy link

@dbsr dbsr commented Mar 3, 2013

This adds a commandline option to not follow symlinks when resolving the cwd.

@b-ryan
Copy link
Owner

b-ryan commented Jul 28, 2015

@dbsr this is a good idea, but I don't think your change is quite the right way to do it. It actually surprised me that the code is currently following symlinks. I think the default should be to not follow them. The get_valid_cwd also is doing more behavior than just following symlinks. I think the proper fix for this would be to return os.getenv['PDW'] in the get_valid_cwd function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants