Add git_stash segment to display number of stashes, if any

[apinkney97]

Addresses issue #114

[phatblat]

👍 Just tested this out and it looks good. One suggestion: add spaces on either side of the stash count text to match the style of other segments (last 2 prompts in screenshot).

See phatblat/powerline-shell@74552cb

[apinkney97]

Sure, if you think it looks better. I removed them to stop the segment being too wide, but I guess we could lose the parentheses instead. Perhaps spaces on either side but with a trailing 's' or asterisk to denote that it's stashes rather than commits ahead/behind (which is why I parenthesised it in the first place).

[b-ryan]

Doing the line count in Python may be more efficient. Would be interested in seeing if that were true.

[b-ryan]

A few new icons were added in #136. I wonder if we should add a new one for this as well rather than the parentheses. The asterisk no longer will work since that is being used to denote conflicts. Another change that could make this align with #136 would be to show only the icon when there is one stash and a number with the icon when there is more than one stash.

[apinkney97]

I'll have a look at reworking this in light of the changes in #136. I think I'll close this and open a new pull request once it's done.

[apinkney97]

I have had a quick glance at some potential unicode glyphs to represent stashes:
u'\u2398' ⎘
u'\u2295' ⊕
u'\u24c8' Ⓢ

I'm leaning towards \u2295 (circled plus). If you have something better in mind, let me know.

[phatblat]

I like the first one (next page) the best out of these. The "circle s" one seems too big.

The last two glyphs:
u'\u21AF' ↯(zigzag arrow)
u'\u2397' ⎗ (previous page)

[b-ryan]

Agreed that the S is too big. The next/previous page are also my favorite of these.

[apinkney97]

I'm happy with 'next page'.

Do you have any preferences on colours? At the moment I've got

GIT_STASH_BG = 221
GIT_STASH_FG = 0

which looks like

[b-ryan]

I don't, really. What you came up with looks fine. I think once I'm using it, maybe I'll have more of an opinion.

[uloco]

Did there ever happen any pull request regarding this issue? Would be happy to have this feature... Really forget my stashes all the time -.-

[apinkney97]

Nope, I totally forgot about this (but shamefully have been using it myself for the past 2.5 years)

The segment code looks to have changed a little since I wrote this, so I'll redo it in the updated style and submit a PR soon (I promise ;))

[apinkney97]

@b-ryan would your preference be for this to be a new segment (as suggested in the original issue, #114) or to be added to the existing git segment?

Ultimately all this does is call git stash list and count the lines, so should not add much overhead. Also, it would be pretty trivial to allow the stash count to be disabled via config if the user doesn't care about it.

[phatblat]

@apinkney97 The git stash call is extra overhead because it's launching a new process and that adds a few milliseconds of delay before the prompt shows up. This is how most of the git segments work now, but each one is adding a few more milliseconds.

I never got around to looking into using something like pygit to do these git lookups in the same process.

[apinkney97]

Ok, I'll probably add it as a new ThreadedSegment in that case.

[b-ryan]

Agreed with @phatblat :)