-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add git stash segment #379
Conversation
Thanks for updating this. The diff shows a lot of changes - I'm not sure why. Perhaps you have to merge the latest master? |
Still waiting for this like crazy... 😞 |
Sorry things have been crazy. Looking at this now. |
Code looks good. The only thing that gives me pause is the symbol used for the segment. Unicode symbols... Not all fonts have support for them. It would be useful to know whether the https://github.com/powerline/fonts fonts support this symbol. In any case, the symbol should be added to https://github.com/b-ryan/powerline-shell/blob/master/powerline_shell/utils.py#L17 rather than be a constant so that the symbol is configurable. |
Anecdotally it seems to render ok on my terminal in all fonts I've tried (10 or so different ones, powerline, non-powerline monospace, and proportional fonts). Possibly my terminal is being clever and pulling it from some font that does contain that glyph. Seems to work even for totally crazy fonts that you'd never use in a terminal that don't support powerline: Not quite sure whether I've done this right (I haven't really poked around inside fonts before) but I think this should list which fonts support a given unicode character:
Admittedly it's not many (3 Again, this is pretty anecdotal, but it seemed to work ok for people who commented on the old PR: #201 (comment) |
Nice - thanks for looking into the fonts & making that change. |
🎉 🎉 🎉 🎉 |
Up-to-date rework of #201, addressing issue #114.
This also refactors some common functions from the version control segments into
utils.py
.