V2 net8 #1054

linkdotnet · 2023-04-27T17:53:43Z

This PR adds net8.0 support and merges the latest main into v2
In addition:

Remove preprocessor switches for <net8.0
Smaller refactorings

Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.51.0.59060 to 8.52.0.60960. - [Release notes](https://github.com/SonarSource/sonar-dotnet/releases) - [Commits](SonarSource/sonar-dotnet@8.51.0.59060...8.52.0.60960) --- updated-dependencies: - dependency-name: SonarAnalyzer.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>

This reverts commit 8ac537a. # Conflicts: # src/AngleSharpWrappers/AngleSharpWrappers.csproj # src/bunit.web/bunit.web.csproj

Release of new minor version v1.15

Release of new minor version v1.16

Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: System.Text.Json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

* Honor preventdefault for events so they don't bubble * Small change to fix the normal bubbling events * Small rename of a private method to better indicate its intention * Improvement and simplification * Build fix by removing an empty statement * Changelog * formatting of the changelog * Updated changelog --------- Co-authored-by: Steven Giesel <stgiesel35@gmail.com>

Bumps [BenchmarkDotNet](https://github.com/dotnet/BenchmarkDotNet) from 0.13.4 to 0.13.5. - [Release notes](https://github.com/dotnet/BenchmarkDotNet/releases) - [Commits](dotnet/BenchmarkDotNet@v0.13.4...v0.13.5) --- updated-dependencies: - dependency-name: BenchmarkDotNet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>

Release of new minor version v1.17

* fix: Better naming for test method * fix: Don't use unknown matcher first * fix: Don't use unknown matcher first * Add attribute

* docs: Use TestContext as base class for Passing parameters to components (#1034) * refactor: Use TestContext as base class * fixes to docs * Indent size 2 * fix getting started and index --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * docs: broken sample code * doc: fixes to sample code to make it compile * docs: added CounterTest.razor * docs: fix code references, added missing samples * docs: change code ref to correct type --------- Co-authored-by: Egil Hansen <egil@assimilated.dk>

Release of new minor version v1.19

egil · 2023-04-27T19:49:22Z

I think we should keep targeting .net 7 and .net 6 while that is still supported. I know we have talked about dropping everything except .NET 8, but sine the plan is to stop doing anything other than fixes for v1 I think we still need to keep supported frameworks around in v2.

linkdotnet · 2023-04-27T19:55:54Z

I think we should keep targeting .net 7 and .net 6 while that is still supported. I know we have talked about dropping everything except .NET 8, but sine the plan is to stop doing anything other than fixes for v1 I think we still need to keep supported frameworks around in v2.

We could use v1 as a legacy version that supports net6.0 and net7.0 for quite a while (both are eol 04/2024) where we only provide bug fixes and v2 will be for >net8.0. Sure that might make bug fixes double the work, but makes new features easier.

Edit: Also it makes maintenance and testing easier in general.

egil · 2023-04-27T20:00:11Z

I think we should keep targeting .net 7 and .net 6 while that is still supported. I know we have talked about dropping everything except .NET 8, but sine the plan is to stop doing anything other than fixes for v1 I think we still need to keep supported frameworks around in v2.

We could use v1 as a legacy version that supports net6.0 and net7.0 for quite a while (both are eol 04/2024) where we only provide bug fixes and v2 will be for >net8.0. Sure that might make bug fixes double the work, but makes new features easier.

Hmm, that could work, but I do think that some features should be backported to v6, e.g. the testing library APIs, and I am not sure that will be too much work to do so when the branches diverge.

linkdotnet · 2023-04-27T20:15:50Z

I think we should keep targeting .net 7 and .net 6 while that is still supported. I know we have talked about dropping everything except .NET 8, but sine the plan is to stop doing anything other than fixes for v1 I think we still need to keep supported frameworks around in v2.

We could use v1 as a legacy version that supports net6.0 and net7.0 for quite a while (both are eol 04/2024) where we only provide bug fixes and v2 will be for >net8.0. Sure that might make bug fixes double the work, but makes new features easier.

Hmm, that could work, but I do think that some features should be backported to v6, e.g. the testing library APIs, and I am not sure that will be too much work to do so when the branches diverge.

That is a fair point - at the moment, I would argue we only have limited "resources" to allocate one of the topics (if we decide we want to have the testing-library stuff in v1 in the first place and if so if it is an extension package or part of the core library anyway).

My main concern with that, as you said, is the increased maintenance - I would prefer to have v2 with a fresh new API (testing-library like). That includes, what we discussed earlier, some reduced surface API and a few other tweaks.

Currently, I am also thinking of deleting stuff we did in the past like WaitForXXXAsync as we tackled the problem.

To sum it up: I would handle v1 like old-stable in Debian where we only provide critical fixes until EOL of the supported version and put our work/brain into v2.

egil · 2023-04-27T20:44:07Z

I would prefer to have v2 with a fresh new API (testing-library like). That includes, what we discussed earlier, some reduced surface API and a few other tweaks.

I've gone back and forth wrt. amount of changes we put into V2.

Currently my take is that we should strive to keep the API surface that users interact with as close to V2 as possible. There are books/blogs/videos/presentation out in the world that should still be valid if at all possible.

The "pubternal" things like interface hierarchies and base types we can be more safely change, as only few/advanced users will be dependent on those parts of the code.

To sum it up: I would handle v1 like old-stable in Debian where we only provide critical fixes until EOL of the supported version and put our work/brain into v2.

That's my plan too.

That said. Keeping support for NET6/7 around may not be a big burden. There are only one or two if def specific to NET7 currently after all. But let's start without net6/7 and add it back in when we have a better picture of what will come to V2 in the coming months. I suspect it's not going to be a big problem to do so.

linkdotnet · 2023-04-27T20:48:32Z

I can live with or without the support of net6/7.
My reasoning goes into the direction that there are new net8 features that have to be behind a #ifdef if we support the "old" version - but you are right, that is nothing in comparison to netstandard / .netcore3 support.

egil

LGTM

egil · 2023-04-27T20:49:43Z

I can live with or without the support of net6/7.
My reasoning goes into the direction that there are new net8 features that have to be behind a #ifdef if we support the "old" version - but you are right, that is nothing in comparison to netstandard / .netcore3 support.

Let's hope that's the case. But I feel good about starting out without it to make it easier to do refactorings and then add NET6/7 in after.

linkdotnet · 2023-04-27T21:08:45Z

Ah some commits are not signed … have to check tomorrow at the PC

egil · 2023-04-27T21:15:14Z

Removed requirement for signed commits. Go ahead and merge.

* build(deps): Bump SonarAnalyzer.CSharp from 8.51.0.59060 to 8.52.0.60960 Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.51.0.59060 to 8.52.0.60960. - [Release notes](https://github.com/SonarSource/sonar-dotnet/releases) - [Commits](SonarSource/sonar-dotnet@8.51.0.59060...8.52.0.60960) --- updated-dependencies: - dependency-name: SonarAnalyzer.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build: set AccelerateBuildsInVisualStudio to true * chore: upgrade anglesharp.diffing to 0.17.1 * docs: update changelog * Revert AngleSharp from 1.0.1 to 0.17.1 This reverts commit 8ac537a. # Conflicts: # src/AngleSharpWrappers/AngleSharpWrappers.csproj # src/bunit.web/bunit.web.csproj * Set version to '1.15' * Set version to '1.16-preview' * Updated CHANGELOG.md for 1.15.5 release * fix: allow semantic comparer to compare IHtmlUnknownElement types * Set version to '1.16' * Set version to '1.17-preview' * Updated CHANGELOG.md for 1.16.2 release * fix: wrong type assignment in doc (#975) * refactor: Use PackageOutputPath instead of -o * build(deps): Bump System.Text.Json from 7.0.1 to 7.0.2 Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: System.Text.Json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Honor preventdefault for events so they don't bubble (#982) * Honor preventdefault for events so they don't bubble * Small change to fix the normal bubbling events * Small rename of a private method to better indicate its intention * Improvement and simplification * Build fix by removing an empty statement * Changelog * formatting of the changelog * Updated changelog --------- Co-authored-by: Steven Giesel <stgiesel35@gmail.com> * build(deps): Bump BenchmarkDotNet from 0.13.4 to 0.13.5 Bumps [BenchmarkDotNet](https://github.com/dotnet/BenchmarkDotNet) from 0.13.4 to 0.13.5. - [Release notes](https://github.com/dotnet/BenchmarkDotNet/releases) - [Commits](dotnet/BenchmarkDotNet@v0.13.4...v0.13.5) --- updated-dependencies: - dependency-name: BenchmarkDotNet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Set version to '1.17' * Set version to '1.18-preview' * Updated CHANGELOG.md for 1.17.2 release * build(deps): Bump AutoFixture from 4.17.0 to 4.18.0 Bumps [AutoFixture](https://github.com/AutoFixture/AutoFixture) from 4.17.0 to 4.18.0. - [Release notes](https://github.com/AutoFixture/AutoFixture/releases) - [Commits](AutoFixture/AutoFixture@v4.17.0...v4.18.0) --- updated-dependencies: - dependency-name: AutoFixture dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): Bump AutoFixture.Xunit2 from 4.17.0 to 4.18.0 Bumps [AutoFixture.Xunit2](https://github.com/AutoFixture/AutoFixture) from 4.17.0 to 4.18.0. - [Release notes](https://github.com/AutoFixture/AutoFixture/releases) - [Commits](AutoFixture/AutoFixture@v4.17.0...v4.18.0) --- updated-dependencies: - dependency-name: AutoFixture.Xunit2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): Bump Microsoft.NET.Test.Sdk from 17.4.1 to 17.5.0 Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.4.1 to 17.5.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.4.1...v17.5.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: Escape text inside html tag and attributes * fix: Added tests for escpable characters * fix: Escape text inside html tag * Added changelog entry * chore: code cleanup * fix: optimize char replacement --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * build(deps): Bump SonarAnalyzer.CSharp from 8.52.0.60960 to 8.53.0.62665 (#988) * build(deps): Bump SonarAnalyzer.CSharp from 8.52.0.60960 to 8.53.0.62665 Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.52.0.60960 to 8.53.0.62665. - [Release notes](https://github.com/SonarSource/sonar-dotnet/releases) - [Commits](SonarSource/sonar-dotnet@8.52.0.60960...8.53.0.62665) --- updated-dependencies: - dependency-name: SonarAnalyzer.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore: code analyzer rules code updates --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Egil Hansen <egil@assimilated.dk> * fix: submit button/input element submits form (#1000) * fix: submit button/input element submits form * handle other edge cases * code clean up * simplify conditionals * Set version to '1.18' * Set version to '1.19-preview' * Updated CHANGELOG.md for 1.18.4 release * chore: use file scoped namespaces * Simplify null coalescing * refactor: use early return and simplify call * fix(nullable): forward nullability correctly (#1013) * fix(nullable): forward nullability correctly * Update src/bunit.web/TestContext.cs Co-authored-by: Egil Hansen <egil@assimilated.dk> --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * docs: improve examples of semantic comparison modifiers * build(deps): Bump AngleSharp.Diffing from 0.17.1 to 0.18.1 Bumps [AngleSharp.Diffing](https://github.com/AngleSharp/AngleSharp.Diffing) from 0.17.1 to 0.18.1. - [Release notes](https://github.com/AngleSharp/AngleSharp.Diffing/releases) - [Changelog](https://github.com/AngleSharp/AngleSharp.Diffing/blob/devel/CHANGELOG.md) - [Commits](AngleSharp/AngleSharp.Diffing@v0.17.1...v0.18.1) --- updated-dependencies: - dependency-name: AngleSharp.Diffing dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Use TestContext as base class for Passing parameters to components (#1034) * refactor: Use TestContext as base class * fixes to docs * Indent size 2 * fix getting started and index --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * docs: broken sample code * doc: fixes to sample code to make it compile * docs: added CounterTest.razor * docs: fix code references, added missing samples * docs: Use TestContext as base class for Passing parameters to components (#1034) * refactor: Use TestContext as base class * fixes to docs * Indent size 2 * fix getting started and index --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * docs: broken sample code * doc: fixes to sample code to make it compile * docs: added CounterTest.razor * docs: fix code references, added missing samples * docs: change code ref to correct type * chore: code clean up * fix: clean up tests * fix: run markup updates in users sync context * fix: synchronize code that reads/writes to the internal render tree in TestRenderer/Renderer * build(deps): Bump SonarAnalyzer.CSharp from 8.54.0.63966 to 8.56.0.67649 Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.54.0.63966 to 8.56.0.67649. - [Release notes](https://github.com/SonarSource/sonar-dotnet/releases) - [Commits](https://github.com/SonarSource/sonar-dotnet/commits/8.56.0.67649) --- updated-dependencies: - dependency-name: SonarAnalyzer.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): Bump dotnet-serve from 1.7.125 to 1.10.155 Bumps [dotnet-serve](https://github.com/natemcmaster/dotnet-serve) from 1.7.125 to 1.10.155. - [Release notes](https://github.com/natemcmaster/dotnet-serve/releases) - [Commits](https://github.com/natemcmaster/dotnet-serve/commits/v1.10.155) --- updated-dependencies: - dependency-name: dotnet-serve dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: Custom elements with attributes throw exception * fix: Better naming for test method (#1048) * fix: Better naming for test method * fix: Don't use unknown matcher first * fix: Don't use unknown matcher first * Add attribute * Merge stable into main (#1050) * docs: Use TestContext as base class for Passing parameters to components (#1034) * refactor: Use TestContext as base class * fixes to docs * Indent size 2 * fix getting started and index --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * docs: broken sample code * doc: fixes to sample code to make it compile * docs: added CounterTest.razor * docs: fix code references, added missing samples * docs: change code ref to correct type --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * Set version to '1.19' * Set version to '1.20-preview' * Updated CHANGELOG.md for 1.19.14 release * Update to net8.0 * Remove preprocessor directives * Wave 2 * Remove net60 dep in test * More changes * Bump actions --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Egil Hansen <egil@assimilated.dk> Co-authored-by: bUnit bot <bot@bunit.dev> Co-authored-by: JelleHissink <Jelle@CodeWise.nl> Co-authored-by: Florian Dohrendorf <LunicLynx@users.noreply.github.com>

dependabot bot and others added 30 commits January 31, 2023 17:25

build: set AccelerateBuildsInVisualStudio to true

71ea086

chore: upgrade anglesharp.diffing to 0.17.1

84ddda0

docs: update changelog

3e1b51c

Revert AngleSharp from 1.0.1 to 0.17.1

92fcdd3

This reverts commit 8ac537a. # Conflicts: # src/AngleSharpWrappers/AngleSharpWrappers.csproj # src/bunit.web/bunit.web.csproj

Set version to '1.15'

4edff38

Set version to '1.16-preview'

56b49f0

Merge branch 'release/v1.15'

991ee41

Merge pull request #967 from bUnit-dev/release/v1.15

cb9bb0e

Release of new minor version v1.15

Updated CHANGELOG.md for 1.15.5 release

1c969be

Merge branch 'stable'

e46eaa6

fix: allow semantic comparer to compare IHtmlUnknownElement types

03a20a2

Set version to '1.16'

d5814ae

Set version to '1.17-preview'

84a48b2

Merge branch 'release/v1.16'

e3328bd

Merge pull request #972 from bUnit-dev/release/v1.16

910674e

Release of new minor version v1.16

Updated CHANGELOG.md for 1.16.2 release

33f9c2d

Merge branch 'stable'

4ca1237

fix: wrong type assignment in doc (#975)

bc21163

Merge branch 'stable'

2fe23ec

refactor: Use PackageOutputPath instead of -o

3910476

Set version to '1.17'

0b0903e

Set version to '1.18-preview'

28a1a16

Merge branch 'release/v1.17'

29663f4

Merge pull request #990 from bUnit-dev/release/v1.17

652393a

Release of new minor version v1.17

Updated CHANGELOG.md for 1.17.2 release

997a71a

Merge branch 'stable'

7dd6d1f

linkdotnet and others added 15 commits April 25, 2023 22:45

fix: Better naming for test method (#1048)

37e4495

* fix: Better naming for test method * fix: Don't use unknown matcher first * fix: Don't use unknown matcher first * Add attribute

Set version to '1.19'

6e19093

Set version to '1.20-preview'

529d124

Merge branch 'release/v1.19'

8653e5d

Merge branch 'stable' into release/v1.19

c0f598f

Merge pull request #1053 from bUnit-dev/release/v1.19

4424322

Release of new minor version v1.19

Updated CHANGELOG.md for 1.19.14 release

dd0cee4

Merge branch 'stable'

33ef779

Merge branch 'stable'

8959284

Update to net8.0

099d48f

Remove preprocessor directives

690da78

Wave 2

2071951

Remove net60 dep in test

5b82f72

More changes

e8b5d6c

linkdotnet requested a review from egil April 27, 2023 17:53

Bump actions

d1a3141

egil approved these changes Apr 27, 2023

View reviewed changes

linkdotnet merged commit 663b824 into v2 Apr 28, 2023

linkdotnet deleted the v2-net8 branch April 28, 2023 06:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

V2 net8 #1054

V2 net8 #1054

Uh oh!

linkdotnet commented Apr 27, 2023

Uh oh!

egil commented Apr 27, 2023

Uh oh!

linkdotnet commented Apr 27, 2023 •

edited

Loading

Uh oh!

egil commented Apr 27, 2023

Uh oh!

linkdotnet commented Apr 27, 2023

Uh oh!

egil commented Apr 27, 2023 •

edited

Loading

Uh oh!

linkdotnet commented Apr 27, 2023

Uh oh!

egil left a comment

Uh oh!

egil commented Apr 27, 2023

Uh oh!

linkdotnet commented Apr 27, 2023

Uh oh!

egil commented Apr 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

V2 net8 #1054

V2 net8 #1054

Uh oh!

Conversation

linkdotnet commented Apr 27, 2023

Uh oh!

egil commented Apr 27, 2023

Uh oh!

linkdotnet commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

egil commented Apr 27, 2023

Uh oh!

linkdotnet commented Apr 27, 2023

Uh oh!

egil commented Apr 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linkdotnet commented Apr 27, 2023

Uh oh!

egil left a comment

Choose a reason for hiding this comment

Uh oh!

egil commented Apr 27, 2023

Uh oh!

linkdotnet commented Apr 27, 2023

Uh oh!

egil commented Apr 27, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

linkdotnet commented Apr 27, 2023 •

edited

Loading

egil commented Apr 27, 2023 •

edited

Loading