Honor preventdefault for events so they don't bubble #982

JelleHissink · 2023-02-17T08:42:51Z

This solves issue #981

src/bunit.web/EventDispatchExtensions/TriggerEventDispatchExtensions.cs

JelleHissink · 2023-02-19T09:56:41Z

Ok, I think I finally understood what @linkdotnet was saying, so I moved the behaviour to where the submit is triggered for the buttons. Could you take another look?

linkdotnet · 2023-02-19T10:44:42Z

Ok, I think I finally understood what @linkdotnet was saying, so I moved the behaviour to where the submit is triggered for the buttons. Could you take another look?

The change itself looks good to me.

A few minor things:

I am not sure if the name of the method still makes sense TriggerFormSubmitBubblingEventAsyncas it might not bubble. Maybe removing the Bubbling part in the middle might do the trick.
Could you add your change to the CHANGELOG.md.
I updated your mainbranch to get the latest changes so your builds have a chance to get green ;).

JelleHissink · 2023-02-19T10:57:12Z

TriggerFormSubmitBubblingEventAsyncas

I don't even know what name would be correct TriggerFormSubmitEventAsync does not do it justice either, as it bubbles the onclick of the button/input and fires submit if needed. I'll think about it for a second and change it with a suggestion ;-)

JelleHissink · 2023-02-19T11:07:07Z

I did an update, it occurred to me that even with stoppropagation the submit would be done. I finally think this is correctly simulating the browser/blazor behaviour now.

linkdotnet · 2023-02-19T13:35:40Z

There are some build errors.

JelleHissink · 2023-02-19T15:56:09Z

The build is fixed, there was one additional ";"

src/bunit.web/EventDispatchExtensions/TriggerEventDispatchExtensions.cs

linkdotnet · 2023-02-19T16:38:21Z

Could you add an entry to the CHANGELOG.md?

CHANGELOG.md

linkdotnet · 2023-02-20T13:17:01Z

Will run the checks and merge it afterward - thanks again @JelleHissink

JelleHissink · 2023-02-20T13:45:29Z

Any idea when it might be released in a new version?

egil · 2023-02-20T17:16:59Z

Any idea when it might be released in a new version?

We can do a release later this week.

egil · 2023-02-22T10:41:26Z

@JelleHissink there is a new release out now.

* build(deps): Bump SonarAnalyzer.CSharp from 8.51.0.59060 to 8.52.0.60960 Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.51.0.59060 to 8.52.0.60960. - [Release notes](https://github.com/SonarSource/sonar-dotnet/releases) - [Commits](SonarSource/sonar-dotnet@8.51.0.59060...8.52.0.60960) --- updated-dependencies: - dependency-name: SonarAnalyzer.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build: set AccelerateBuildsInVisualStudio to true * chore: upgrade anglesharp.diffing to 0.17.1 * docs: update changelog * Revert AngleSharp from 1.0.1 to 0.17.1 This reverts commit 8ac537a. # Conflicts: # src/AngleSharpWrappers/AngleSharpWrappers.csproj # src/bunit.web/bunit.web.csproj * Set version to '1.15' * Set version to '1.16-preview' * Updated CHANGELOG.md for 1.15.5 release * fix: allow semantic comparer to compare IHtmlUnknownElement types * Set version to '1.16' * Set version to '1.17-preview' * Updated CHANGELOG.md for 1.16.2 release * fix: wrong type assignment in doc (#975) * refactor: Use PackageOutputPath instead of -o * build(deps): Bump System.Text.Json from 7.0.1 to 7.0.2 Bumps [System.Text.Json](https://github.com/dotnet/runtime) from 7.0.1 to 7.0.2. - [Release notes](https://github.com/dotnet/runtime/releases) - [Commits](dotnet/runtime@v7.0.1...v7.0.2) --- updated-dependencies: - dependency-name: System.Text.Json dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Honor preventdefault for events so they don't bubble (#982) * Honor preventdefault for events so they don't bubble * Small change to fix the normal bubbling events * Small rename of a private method to better indicate its intention * Improvement and simplification * Build fix by removing an empty statement * Changelog * formatting of the changelog * Updated changelog --------- Co-authored-by: Steven Giesel <stgiesel35@gmail.com> * build(deps): Bump BenchmarkDotNet from 0.13.4 to 0.13.5 Bumps [BenchmarkDotNet](https://github.com/dotnet/BenchmarkDotNet) from 0.13.4 to 0.13.5. - [Release notes](https://github.com/dotnet/BenchmarkDotNet/releases) - [Commits](dotnet/BenchmarkDotNet@v0.13.4...v0.13.5) --- updated-dependencies: - dependency-name: BenchmarkDotNet dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Set version to '1.17' * Set version to '1.18-preview' * Updated CHANGELOG.md for 1.17.2 release * build(deps): Bump AutoFixture from 4.17.0 to 4.18.0 Bumps [AutoFixture](https://github.com/AutoFixture/AutoFixture) from 4.17.0 to 4.18.0. - [Release notes](https://github.com/AutoFixture/AutoFixture/releases) - [Commits](AutoFixture/AutoFixture@v4.17.0...v4.18.0) --- updated-dependencies: - dependency-name: AutoFixture dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): Bump AutoFixture.Xunit2 from 4.17.0 to 4.18.0 Bumps [AutoFixture.Xunit2](https://github.com/AutoFixture/AutoFixture) from 4.17.0 to 4.18.0. - [Release notes](https://github.com/AutoFixture/AutoFixture/releases) - [Commits](AutoFixture/AutoFixture@v4.17.0...v4.18.0) --- updated-dependencies: - dependency-name: AutoFixture.Xunit2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): Bump Microsoft.NET.Test.Sdk from 17.4.1 to 17.5.0 Bumps [Microsoft.NET.Test.Sdk](https://github.com/microsoft/vstest) from 17.4.1 to 17.5.0. - [Release notes](https://github.com/microsoft/vstest/releases) - [Changelog](https://github.com/microsoft/vstest/blob/main/docs/releases.md) - [Commits](microsoft/vstest@v17.4.1...v17.5.0) --- updated-dependencies: - dependency-name: Microsoft.NET.Test.Sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: Escape text inside html tag and attributes * fix: Added tests for escpable characters * fix: Escape text inside html tag * Added changelog entry * chore: code cleanup * fix: optimize char replacement --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * build(deps): Bump SonarAnalyzer.CSharp from 8.52.0.60960 to 8.53.0.62665 (#988) * build(deps): Bump SonarAnalyzer.CSharp from 8.52.0.60960 to 8.53.0.62665 Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.52.0.60960 to 8.53.0.62665. - [Release notes](https://github.com/SonarSource/sonar-dotnet/releases) - [Commits](SonarSource/sonar-dotnet@8.52.0.60960...8.53.0.62665) --- updated-dependencies: - dependency-name: SonarAnalyzer.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * chore: code analyzer rules code updates --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Egil Hansen <egil@assimilated.dk> * fix: submit button/input element submits form (#1000) * fix: submit button/input element submits form * handle other edge cases * code clean up * simplify conditionals * Set version to '1.18' * Set version to '1.19-preview' * Updated CHANGELOG.md for 1.18.4 release * chore: use file scoped namespaces * Simplify null coalescing * refactor: use early return and simplify call * fix(nullable): forward nullability correctly (#1013) * fix(nullable): forward nullability correctly * Update src/bunit.web/TestContext.cs Co-authored-by: Egil Hansen <egil@assimilated.dk> --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * docs: improve examples of semantic comparison modifiers * build(deps): Bump AngleSharp.Diffing from 0.17.1 to 0.18.1 Bumps [AngleSharp.Diffing](https://github.com/AngleSharp/AngleSharp.Diffing) from 0.17.1 to 0.18.1. - [Release notes](https://github.com/AngleSharp/AngleSharp.Diffing/releases) - [Changelog](https://github.com/AngleSharp/AngleSharp.Diffing/blob/devel/CHANGELOG.md) - [Commits](AngleSharp/AngleSharp.Diffing@v0.17.1...v0.18.1) --- updated-dependencies: - dependency-name: AngleSharp.Diffing dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * docs: Use TestContext as base class for Passing parameters to components (#1034) * refactor: Use TestContext as base class * fixes to docs * Indent size 2 * fix getting started and index --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * docs: broken sample code * doc: fixes to sample code to make it compile * docs: added CounterTest.razor * docs: fix code references, added missing samples * docs: Use TestContext as base class for Passing parameters to components (#1034) * refactor: Use TestContext as base class * fixes to docs * Indent size 2 * fix getting started and index --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * docs: broken sample code * doc: fixes to sample code to make it compile * docs: added CounterTest.razor * docs: fix code references, added missing samples * docs: change code ref to correct type * chore: code clean up * fix: clean up tests * fix: run markup updates in users sync context * fix: synchronize code that reads/writes to the internal render tree in TestRenderer/Renderer * build(deps): Bump SonarAnalyzer.CSharp from 8.54.0.63966 to 8.56.0.67649 Bumps [SonarAnalyzer.CSharp](https://github.com/SonarSource/sonar-dotnet) from 8.54.0.63966 to 8.56.0.67649. - [Release notes](https://github.com/SonarSource/sonar-dotnet/releases) - [Commits](https://github.com/SonarSource/sonar-dotnet/commits/8.56.0.67649) --- updated-dependencies: - dependency-name: SonarAnalyzer.CSharp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): Bump dotnet-serve from 1.7.125 to 1.10.155 Bumps [dotnet-serve](https://github.com/natemcmaster/dotnet-serve) from 1.7.125 to 1.10.155. - [Release notes](https://github.com/natemcmaster/dotnet-serve/releases) - [Commits](https://github.com/natemcmaster/dotnet-serve/commits/v1.10.155) --- updated-dependencies: - dependency-name: dotnet-serve dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix: Custom elements with attributes throw exception * fix: Better naming for test method (#1048) * fix: Better naming for test method * fix: Don't use unknown matcher first * fix: Don't use unknown matcher first * Add attribute * Merge stable into main (#1050) * docs: Use TestContext as base class for Passing parameters to components (#1034) * refactor: Use TestContext as base class * fixes to docs * Indent size 2 * fix getting started and index --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * docs: broken sample code * doc: fixes to sample code to make it compile * docs: added CounterTest.razor * docs: fix code references, added missing samples * docs: change code ref to correct type --------- Co-authored-by: Egil Hansen <egil@assimilated.dk> * Set version to '1.19' * Set version to '1.20-preview' * Updated CHANGELOG.md for 1.19.14 release * Update to net8.0 * Remove preprocessor directives * Wave 2 * Remove net60 dep in test * More changes * Bump actions --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Egil Hansen <egil@assimilated.dk> Co-authored-by: bUnit bot <bot@bunit.dev> Co-authored-by: JelleHissink <Jelle@CodeWise.nl> Co-authored-by: Florian Dohrendorf <LunicLynx@users.noreply.github.com>

Honor preventdefault for events so they don't bubble

b4bde76

JelleHissink mentioned this pull request Feb 17, 2023

A submit button in a form submits the form when preventDefault is set #981

Closed

linkdotnet reviewed Feb 17, 2023

View reviewed changes

src/bunit.web/EventDispatchExtensions/TriggerEventDispatchExtensions.cs Outdated Show resolved Hide resolved

Small change to fix the normal bubbling events

3989d99

Merge branch 'main' into main

11b4c2a

JelleHissink added 3 commits February 19, 2023 11:58

Small rename of a private method to better indicate its intention

fdfcab2

Merge branch 'main' of https://github.com/JelleHissink/bUnit

98b31da

Improvement and simplification

ac8ac6f

Build fix by removing an empty statement

4e76f9d

linkdotnet reviewed Feb 19, 2023

View reviewed changes

src/bunit.web/EventDispatchExtensions/TriggerEventDispatchExtensions.cs Show resolved Hide resolved

JelleHissink added 2 commits February 19, 2023 18:37

Changelog

5bc6939

formatting of the changelog

56c22b7

linkdotnet reviewed Feb 20, 2023

View reviewed changes

CHANGELOG.md Outdated Show resolved Hide resolved

Updated changelog

2d3b3d9

linkdotnet approved these changes Feb 20, 2023

View reviewed changes

linkdotnet merged commit c094d30 into bUnit-dev:main Feb 20, 2023

egil mentioned this pull request Feb 25, 2023

Regression: Click on a submit button triggers an exception #996

Closed

Uh oh!

Honor preventdefault for events so they don't bubble #982

Honor preventdefault for events so they don't bubble #982

Uh oh!

Conversation

JelleHissink commented Feb 17, 2023

Uh oh!

Uh oh!

JelleHissink commented Feb 19, 2023

Uh oh!

linkdotnet commented Feb 19, 2023

Uh oh!

JelleHissink commented Feb 19, 2023

Uh oh!

JelleHissink commented Feb 19, 2023

Uh oh!

linkdotnet commented Feb 19, 2023

Uh oh!

JelleHissink commented Feb 19, 2023

Uh oh!

Uh oh!

linkdotnet commented Feb 19, 2023

Uh oh!

Uh oh!

linkdotnet commented Feb 20, 2023

Uh oh!

JelleHissink commented Feb 20, 2023

Uh oh!

egil commented Feb 20, 2023

Uh oh!

egil commented Feb 22, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants