-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any opposition to making cacheDirectory default true? #199
Comments
My reasoning was that is not something that loaders do by default (in fact I only know babel-loader that has such option), and as such, users might not be aware of that option. I'm not against turning it on by default, but I feel that it might be dangerous. |
Understood - can you think of any instances in which it would be dangerous to do? Webpack (unfortunately) doesn't do file cache now but I believe it will in the near future of the 2.x branch. Plenty of other build tools do caching to Potentially we could run into a disk space issue, but properly-configured systems should be tmpreaping or something similar. Perhaps |
Any ETA for Webpack 2.x ? It might not be worth the effort if they're planning to release it soon. |
Just realised that this option existed and got a big perf boost. There will always be people using this package without reading through the readme (In my case I inherited the project, and I think the original was built using a scaffolder anyway). Seems like this should be performant by default if possible. |
Yeah I really don't see any reason to not make this default to /tmp.
|
What are the use cases of |
|
I don't think I'm in favor of this. The cache doesn't invalidate well in all cases and means you're writing a bunch of files to disk that you might not actually want, like if you're doing a build for production. |
@loganfsmyth, are there any downsides of setting |
Been fielding a lot of questions from webpack users about slow builds; enabling
cacheDirectory
usually helps a lot. Is there a good reason to keep it disabled by default?The text was updated successfully, but these errors were encountered: