Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arnold/material UI deprecation fix #5

Merged
merged 5 commits into from
Jan 21, 2025

Conversation

apinkhasov101
Copy link
Collaborator

References issue #. Please review this @teammember1, @teamMember2.

Types of changes

  • Bugfix (change which fixes an issue)
  • New feature (change which adds functionality)
  • [ X] Refactor (change which changes the codebase without affecting its external behavior)
  • [ X] Non-breaking change (fix or feature that would cause existing functionality to work as expected)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Purpose

  • Updated deprecated SCSS syntax so as to not cause errors.
  • Improved speed for build and better cacheing
  • Updated dependencies to relevant/wanted versions

Approach

  • Changed import statements to @use ... as * statements.
  • Added a cacheDirectory to speed up builds and set to true.
  • The output configuration specifies the dist folder and bundle.js file. For better caching and versioning, we changed it to use content hashing in the filename.
  • npm outdated and npm install in cli

Learning

Screenshot(s)

n/a

Copy link
Collaborator

@ashleybisram ashleybisram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'adaptV4Theme' has also been removed in this PR

@ashleybisram ashleybisram merged commit f446fd1 into dev Jan 21, 2025
2 checks passed
@ashleybisram ashleybisram deleted the Arnold/MaterialUIDeprecationFix branch January 21, 2025 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants