Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make FromName an attribute in app.toml #188

Closed
gitferry opened this issue Nov 3, 2022 · 1 comment
Closed

Make FromName an attribute in app.toml #188

gitferry opened this issue Nov 3, 2022 · 1 comment
Assignees
@gitferry

Comments

@gitferry
Copy link
Contributor

gitferry commented Nov 3, 2022

To sign a BLS-sig transaction, the signer needs to access the keyring by the key name, which is set as FromName of the client context. Currently, it is hard coded with the file path. Should change it into an attribute in app.toml so that the validator will have control.
@gitferry gitferry self-assigned this Nov 3, 2022
@gitferry gitferry mentioned this issue Nov 8, 2022
Closed
@gitferry
Copy link
Contributor Author

Resolved by #199

vitsalis pushed a commit that referenced this issue Jan 21, 2024
@maurolacy
Remove 'omitempty' from int fields (#188)
234dc86
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gitferry gitferry

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gitferry