Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add signer key name into app custom config #199

Merged
merged 1 commit into from
Nov 13, 2022
Merged

chore: Add signer key name into app custom config #199

merged 1 commit into from
Nov 13, 2022

Conversation

gitferry
Copy link
Contributor

This PR replaces #194.

This PR substitutes the hardcoded key name parameter with a config attribute in app.toml which is in full control of the validator.

@gitferry gitferry changed the base branch from main to dev November 12, 2022 03:42
vitsalis
vitsalis approved these changes Nov 12, 2022
View reviewed changes
Copy link
Member

@vitsalis vitsalis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super clean, great work!

@gitferry gitferry mentioned this pull request Nov 13, 2022
Closed
@gitferry gitferry merged commit 4f610fe into dev Nov 13, 2022
@gitferry gitferry deleted the checkpointing/add-key-name-config branch November 13, 2022 03:02
@gitferry gitferry mentioned this pull request Nov 15, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitsalis vitsalis vitsalis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gitferry @vitsalis